Adding tablet UI for home by dessalines · Pull Request #1723 · LemmyNet/jerboa

dessalines · 2024-11-20T15:17:06Z

I've added:

A list-detail layout for home only.
Switching from a Scaffold.bottomBar to an adaptive navigation bar.
I've tested the regular phone layout, and it works okay.

Example of tablet UI:

Screen_Recording_20241120_111952_Jerboa.Debug.mp4

Fixes #127

dessalines · 2024-11-20T16:26:29Z

                appSettings = appSettings,
            ) {
-                val appState = rememberJerboaAppState()
+                Surface(modifier = Modifier.fillMaxSize()) {


Only change here is wrapping everything in this surface: its necessary for the navigation bar scaffold, and is in most of the examples.

Does it need to be all they way up here?

dessalines · 2024-11-20T16:32:20Z

    postActionBarMode: PostActionBarMode,
    swipeToActionPreset: SwipeToActionPreset,
    padding: PaddingValues,
+    onPostClick: (PostView) -> Unit,


We need to highjack this action, because the list-detail view uses its own pseudo navigation.

dessalines · 2024-11-20T16:35:13Z

+                Scaffold(
+                    snackbarHost = { JerboaSnackbarHost(snackbarHostState) },
+                    content = { padding ->


It's strange to embed a scaffold within the adaptive scaffold, but its the only way to pass the snackbarhost for the error messages.

MV-GH · 2024-11-20T21:34:41Z

        this.getData()
    }

+    fun reInitializeWithNewId(id: Either<PostId, CommentId>) {


I haven't fully checked it out

But I think the idea was rather that you would recreate a new postViewModel each time.

I haven't this out yet but this might not play well with the state that won't be remembered. Like sorts.

MV-GH · 2024-11-20T21:42:51Z

-        val window = (LocalContext.current as Activity).window
-        val colorScheme = MaterialTheme.colorScheme
-
-        DisposableEffect(Unit) {


I see this is also gone but this was really necessary for the navigation bar to look the same as system navigation bar.

It looked quite odd. I'll check it out later to see how this looks now.

I don't see any need for these now in the jetpack compose code, maybe they were necessary once, but now with edgeToedge , it seems to handle the navbar coloring fine.

Not on older API levels

Before

After

I prefer we keep it, this was tested on Android 12, so not even that old.

…ablet

MV-GH · 2024-11-20T22:07:24Z

Ill have time this weekend for a proper review + testing

dessalines · 2024-11-20T22:08:30Z

Sweet, thx.

MV-GH · 2024-11-26T01:23:08Z

Mb I'll have time tomorrow

MV-GH · 2024-11-26T22:02:20Z

I am getting crashes

stacktrace

FATAL EXCEPTION: main
Process: com.jerboa.debug, PID: 2623
java.lang.NoSuchMethodError: No interface method removeFirst()Ljava/lang/Object; in class Ljava/util/List; or its super classes (declaration of 'java.util.List' appears in /apex/com.android.art/javalib/core-oj.jar)
	at com.jerboa.UtilsKt.getCommentParentId(Utils.kt:824)
	at com.jerboa.UtilsKt.recCreateAndGenMissingCommentData(Utils.kt:186)
	at com.jerboa.UtilsKt.buildCommentsTree(Utils.kt:166)
	at com.jerboa.ui.components.post.PostPaneKt$PostPane$14$2.invoke$lambda$36(PostPane.kt:491)
	at com.jerboa.ui.components.post.PostPaneKt$PostPane$14$2.$r8$lambda$3mSIQh7EFo9ZE2NxXXAs9Y27qzY(Unknown Source:0)
	at com.jerboa.ui.components.post.PostPaneKt$PostPane$14$2$$ExternalSyntheticLambda22.invoke(D8$$SyntheticClass:0)
	at androidx.compose.foundation.lazy.LazyListIntervalContent.<init>(LazyListIntervalContent.kt:34)
	at androidx.compose.foundation.lazy.LazyListItemProviderKt$rememberLazyListItemProviderLambda$1$intervalContentState$1.invoke(LazyListItemProvider.kt:49)
	at androidx.compose.foundation.lazy.LazyListItemProviderKt$rememberLazyListItemProviderLambda$1$intervalContentState$1.invoke(LazyListItemProvider.kt:48)
	at androidx.compose.runtime.snapshots.Snapshot$Companion.observe(Snapshot.kt:503)
	at androidx.compose.runtime.DerivedSnapshotState.currentRecord(DerivedState.kt:200)
	at androidx.compose.runtime.DerivedSnapshotState.getValue(DerivedState.kt:272)
	at androidx.compose.foundation.lazy.LazyListItemProviderKt$rememberLazyListItemProviderLambda$1$itemProviderState$1.invoke(LazyListItemProvider.kt:52)
	at androidx.compose.foundation.lazy.LazyListItemProviderKt$rememberLazyListItemProviderLambda$1$itemProviderState$1.invoke(LazyListItemProvider.kt:51)
	at androidx.compose.runtime.snapshots.Snapshot$Companion.observe(Snapshot.kt:503)
	at androidx.compose.runtime.DerivedSnapshotState.currentRecord(DerivedState.kt:200)
	at androidx.compose.runtime.DerivedSnapshotState.getCurrentRecord(DerivedState.kt:279)
	at androidx.compose.runtime.snapshots.SnapshotStateObserver$ObservedScopeMap.recordRead(SnapshotStateObserver.kt:463)
	at androidx.compose.runtime.snapshots.SnapshotStateObserver$ObservedScopeMap.recordRead(SnapshotStateObserver.kt:436)
	at androidx.compose.runtime.snapshots.SnapshotStateObserver$readObserver$1.invoke(SnapshotStateObserver.kt:168)
	at androidx.compose.runtime.snapshots.SnapshotStateObserver$readObserver$1.invoke(SnapshotStateObserver.kt:165)
	at androidx.compose.runtime.DerivedSnapshotState.getValue(DerivedState.kt:267)
	at androidx.compose.foundation.lazy.LazyListItemProviderKt$rememberLazyListItemProviderLambda$1$1.get(LazyListItemProvider.kt:61)
	at kotlin.jvm.internal.PropertyReference0.invoke(PropertyReference0.java:35)
	at androidx.compose.foundation.lazy.layout.LazyLayoutKt$LazyLayout$3$itemContentFactory$1$1.invoke(LazyLayout.kt:84)
	at androidx.compose.foundation.lazy.layout.LazyLayoutKt$LazyLayout$3$itemContentFactory$1$1.invoke(LazyLayout.kt:84)
	at androidx.compose.foundation.lazy.layout.LazyLayoutMeasureScopeImpl.<init>(LazyLayoutMeasureScope.kt:109)
	at androidx.compose.foundation.lazy.layout.LazyLayoutKt$LazyLayout$3$2$1.invoke-0kLqBqw(LazyLayout.kt:114)
	at androidx.compose.foundation.lazy.layout.LazyLayoutKt$LazyLayout$3$2$1.invoke(LazyLayout.kt:112)
	at androidx.compose.ui.layout.LayoutNodeSubcompositionsState$createMeasurePolicy$1.measure-3p2s80s(SubcomposeLayout.kt:725)
	at androidx.compose.ui.node.InnerNodeCoordinator$LookaheadDelegateImpl.measure-BRTryo0(InnerNodeCoordinator.kt:83)
	at androidx.compose.ui.graphics.SimpleGraphicsLayerModifier.measure-3p2s80s(GraphicsLayerModifier.kt:646)
	at androidx.compose.ui.node.LayoutModifierNodeCoordinator$LookaheadDelegateForLayoutModifierNode.measure-BRTryo0(LayoutModifierNodeCoordinator.kt:94)
	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$performLookaheadMeasure$1.invoke(LayoutNodeLayoutDelegate.kt:1802)
	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$performLookaheadMeasure$1.invoke(LayoutNodeLayoutDelegate.kt:1801)
	at androidx.compose.runtime.snapshots.Snapshot$Companion.observe(Snapshot.kt:503)
	at androidx.compose.runtime.snapshots.SnapshotStateObserver$ObservedScopeMap.observe(SnapshotStateObserver.kt:502)
	at androidx.compose.runtime.snapshots.SnapshotStateObserver.observeReads(SnapshotStateObserver.kt:258)
	at androidx.compose.ui.node.OwnerSnapshotObserver.observeReads$ui_release(OwnerSnapshotObserver.kt:133)
	at androidx.compose.ui.node.OwnerSnapshotObserver.observeMeasureSnapshotReads$ui_release(OwnerSnapshotObserver.kt:111)
	at androidx.compose.ui.node.OwnerSnapshotObserver.observeMeasureSnapshotReads$ui_release$default(OwnerSnapshotObserver.kt:105)
	at androidx.compose.ui.node.LayoutNodeLayoutDelegate.performLookaheadMeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:1801)
	at androidx.compose.ui.node.LayoutNodeLayoutDelegate.access$performLookaheadMeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:40)
	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$LookaheadPassDelegate.remeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:1431)
	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$LookaheadPassDelegate.measure-BRTryo0(LayoutNodeLayoutDelegate.kt:1368)
	at androidx.compose.foundation.layout.BoxMeasurePolicy.measure-3p2s80s(Box.kt:173)
	at androidx.compose.ui.node.InnerNodeCoordinator$LookaheadDelegateImpl.measure-BRTryo0(InnerNodeCoordinator.kt:83)
	at androidx.compose.foundation.layout.FillNode.measure-3p2s80s(Size.kt:699)
	at androidx.compose.ui.node.LayoutModifierNodeCoordinator$LookaheadDelegateForLayoutModifierNode.measure-BRTryo0(LayoutModifierNodeCoordinator.kt:94)
	at androidx.compose.foundation.layout.PaddingValuesModifier.measure-3p2s80s(Padding.kt:472)
	at androidx.compose.ui.node.LayoutModifierNodeCoordinator$LookaheadDelegateForLayoutModifierNode.measure-BRTryo0(LayoutModifierNodeCoordinator.kt:94)
	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$performLookaheadMeasure$1.invoke(LayoutNodeLayoutDelegate.kt:1802)
	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$performLookaheadMeasure$1.invoke(LayoutNodeLayoutDelegate.kt:1801)
	at androidx.compose.runtime.snapshots.Snapshot$Companion.observe(Snapshot.kt:503)
	at androidx.compose.runtime.snapshots.SnapshotStateObserver$ObservedScopeMap.observe(SnapshotStateObserver.kt:502)
	at androidx.compose.runtime.snapshots.SnapshotStateObserver.observeReads(SnapshotStateObserver.kt:258)
	at androidx.compose.ui.node.OwnerSnapshotObserver.observeReads$ui_release(OwnerSnapshotObserver.kt:133)
	at androidx.compose.ui.node.OwnerSnapshotObserver.observeMeasureSnapshotReads$ui_release(OwnerSnapshotObserver.kt:111)
	at androidx.compose.ui.node.OwnerSnapshotObserver.observeMeasureSnapshotReads$ui_release$default(OwnerSnapshotObserver.kt:105)
	at androidx.compose.ui.node.LayoutNodeLayoutDelegate.performLookaheadMeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:1801)
	at androidx.compose.ui.node.LayoutNodeLayoutDelegate.access$performLookaheadMeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:40)
	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$LookaheadPassDelegate.remeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:1431)
	at androidx.compose.ui.node.LayoutNode.lookaheadRemeasure-_Sx5XlM$ui_release(LayoutNode.kt:1204)
	at androidx.compose.ui.node.LayoutNode.lookaheadRemeasure-_Sx5XlM$ui_release$default(LayoutNode.kt:1198)
	at androidx.compose.ui.node.MeasureAndLayoutDelegate.doLookaheadRemeasure-sdFAvZA(MeasureAndLayoutDelegate.kt:349)
	at androidx.compose.ui.node.MeasureAndLayoutDelegate.remeasureAndRelayoutIfNeeded(MeasureAndLayoutDelegate.kt:555)
	at androidx.compose.ui.node.MeasureAndLayoutDelegate.onlyRemeasureIfScheduled(MeasureAndLayoutDelegate.kt:660)
	at androidx.compose.ui.node.MeasureAndLayoutDelegate.forceMeasureTheSubtreeInternal(MeasureAndLayoutDelegate.kt:686)
	at androidx.compose.ui.node.MeasureAndLayoutDelegate.forceMeasureTheSubtreeInternal(MeasureAndLayoutDelegate.kt:693)
	at androidx.compose.ui.node.MeasureAndLayoutDelegate.forceMeasureTheSubtree(MeasureAndLayoutDelegate.kt:649)
	at androidx.compose.ui.platform.AndroidComposeView.forceMeasureTheSubtree(AndroidComposeView.android.kt:1299)
	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$LookaheadPassDelegate.remeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:1441)
	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$LookaheadPassDelegate.measure-BRTryo0(LayoutNodeLayoutDelegate.kt:1368)
	at androidx.compose.animation.AnimatedEnterExitMeasurePolicy.measure-3p2s80s(AnimatedVisibility.kt:812)
	at androidx.compose.ui.node.InnerNodeCoordinator$LookaheadDelegateImpl.measure-BRTryo0(InnerNodeCoordinator.kt:83)
	at androidx.compose.animation.EnterExitTransitionModifierNode.measure-3p2s80s(EnterExitTransition.kt:1160)
	at androidx.compose.ui.node.LayoutModifierNodeCoordinator$LookaheadDelegateForLayoutModifierNode.measure-BRTryo0(LayoutModifierNodeCoordinator.kt:94)
	at androidx.compose.ui.graphics.BlockGraphicsLayerModifier.measure-3p2s80s(GraphicsLayerModifier.kt:578)
	at androidx.compose.ui.node.LayoutModifierNodeCoordinator$LookaheadDelegateForLayoutModifierNode.measure-BRTryo0(LayoutModifierNodeCoordinator.kt:94)
	at androidx.compose.animation.AnimatedVisibilityKt$AnimatedVisibilityImpl$1$1.invoke-3p2s80s(AnimatedVisibility.kt:699)
	at androidx.compose.animation.AnimatedVisibilityKt$AnimatedVisibilityImpl$1$1.invoke(AnimatedVisibility.kt:698)
	at androidx.compose.ui.layout.LayoutModifierImpl.measure-3p2s80s(LayoutModifier.kt:294)
	at androidx.compose.ui.node.LayoutModifierNodeCoordinator$LookaheadDelegateForLayoutModifierNode.measure-BRTryo0(LayoutModifierNodeCoordinator.kt:94)
	at androidx.compose.ui.graphics.SimpleGraphicsLayerModifier.measure-3p2s80s(GraphicsLayerModifier.kt:646)
	at androidx.compose.ui.node.LayoutModifierNodeCoordinator$LookaheadDelegateForLayoutModifierNode.measure-BRTryo0(LayoutModifierNodeCoordinator.kt:94)
	at androidx.compose.material3.adaptive.layout.AnimateBoundsNode.measure-3p2s80s(AnimateBoundsModifier.kt:116)
	at androidx.compose.ui.node.LayoutModifierNodeCoordinator$LookaheadDelegateForLayoutModifierNode.measure-BRTryo0(LayoutModifierNodeCoordinator.kt:94)
	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$performLookaheadMeasure$1.invoke(LayoutNodeLayoutDelegate.kt:1802)
	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$performLookaheadMeasure$1.invoke(LayoutNodeLayoutDelegate.kt:1801)
	at androidx.compose.runtime.snapshots.Snapshot$Companion.observe(Snapshot.kt:2441)
	at androidx.compose.runtime.snapshots.SnapshotStateObserver$ObservedScopeMap.observe(SnapshotStateObserver.kt:502)
	at androidx.compose.runtime.snapshots.SnapshotStateObserver.observeReads(SnapshotStateObserver.kt:258)
	at androidx.compose.ui.node.OwnerSnapshotObserver.observeReads$ui_release(OwnerSnapshotObserver.kt:133)
	at androidx.compose.ui.node.OwnerSnapshotObserver.observeMeasureSnapshotReads$ui_release(OwnerSnapshotObserver.kt:111)
	at androidx.compose.ui.node.OwnerSnapshotObserver.observeMeasureSnapshotReads$ui_release$default(OwnerSnapshotObserver.kt:105)
	at androidx.compose.ui.node.LayoutNodeLayoutDelegate.performLookaheadMeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:1801)
	at androidx.compose.ui.node.LayoutNodeLayoutDelegate.access$performLookaheadMeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:40)
	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$LookaheadPassDelegate.remeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:1431)
	at androidx.compose.ui.node.LayoutNode.lookaheadRemeasure-_Sx5XlM$ui_release(LayoutNode.kt:1204)
	at androidx.compose.ui.node.LayoutNode.lookaheadRemeasure-_Sx5XlM$ui_release$default(LayoutNode.kt:1198)
	at androidx.compose.ui.node.MeasureAndLayoutDelegate.doLookaheadRemeasure-sdFAvZA(MeasureAndLayoutDelegate.kt:349)
	at androidx.compose.ui.node.MeasureAndLayoutDelegate.remeasureAndRelayoutIfNeeded(MeasureAndLayoutDelegate.kt:555)
	at androidx.compose.ui.node.MeasureAndLayoutDelegate.remeasureAndRelayoutIfNeeded$default(MeasureAndLayoutDelegate.kt:534)
	at androidx.compose.ui.node.MeasureAndLayoutDelegate.measureAndLayout(MeasureAndLayoutDelegate.kt:390)
	at androidx.compose.ui.platform.AndroidComposeView.measureAndLayout(AndroidComposeView.android.kt:1268)
	at androidx.compose.ui.node.Owner.measureAndLayout$default(Owner.kt:248)
	at androidx.compose.ui.platform.AndroidComposeView.dispatchDraw(AndroidComposeView.android.kt:1556)
	at android.view.View.draw(View.java:22647)
	at android.view.View.updateDisplayListIfDirty(View.java:21519)
	at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4512)
	at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4485)
	at android.view.View.updateDisplayListIfDirty(View.java:21475)
	at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4512)
	at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4485)
	at android.view.View.updateDisplayListIfDirty(View.java:21475)
	at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4512)
	at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4485)
	at android.view.View.updateDisplayListIfDirty(View.java:21475)
	at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4512)
	at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4485)
	at android.view.View.updateDisplayListIfDirty(View.java:21475)
	at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4512)
	at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4485)
	at android.view.View.updateDisplayListIfDirty(View.java:21475)
	at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4512)
	at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4485)
	at android.view.View.updateDisplayListIfDirty(View.java:21475)
	at android.view.ThreadedRenderer.updateViewTreeDisplayList(ThreadedRenderer.java:534)
	at android.view.ThreadedRenderer.updateRootDisplayList(ThreadedRenderer.java:540)
	at android.view.ThreadedRenderer.draw(ThreadedRenderer.java:616)
	at android.view.ViewRootImpl.draw(ViewRootImpl.java:4421)
	at android.view.ViewRootImpl.performDraw(ViewRootImpl.java:4149)
	at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:3309)
	at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:2126)
	at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:8653)
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1037)
	at android.view.Choreographer.doCallbacks(Choreographer.java:845)
	at android.view.Choreographer.doFrame(Choreographer.java:780)
	at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1022)
	at android.os.Handler.handleCallback(Handler.java:938)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loopOnce(Looper.java:201)
	at android.os.Looper.loop(Looper.java:288)
	at android.app.ActivityThread.main(ActivityThread.java:7839)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)

dessalines · 2024-11-27T15:30:31Z

Unfortunately it'll be ~a week before I can check this one out.

MV-GH · 2025-02-13T22:19:34Z

Those crashes are related to this.

…ablet

dessalines · 2025-02-18T22:07:12Z

K, updated, so hopefully this won't crash.

MV-GH · 2025-02-18T22:46:51Z

@@ -1,4 +1,3 @@
 <?xml version="1.0" encoding="utf-8"?>
 <resources>
-    <string name="app_name">Jerboa (ОТЛАДКА)</string>


If you remove this then you might as well remove the entire file

Will do. There's a lot of other translation lints that android studio is telling us to fix, but that can be done in a separate PR.

Eventually we can switch to weblate, I've done that for a few other repos now.

MV-GH · 2025-02-18T22:48:52Z

            </intent-filter>

-            <intent-filter>
+            <intent-filter android:autoVerify="true">


Are we actually hosting a Digital Asset Links json on all lemmy domains that have Jerboa in there?

https://developer.android.com/training/app-links/verify-android-applinks

Nope, I shouldn't have followed that manifest lint. I'll remove.

MV-GH · 2025-02-18T22:49:54Z

 fun amMod(
    moderators: List<PersonId>?,
    myId: PersonId,
-): Boolean = moderators?.contains(myId) ?: false


Imo the previous reads easier but you can leave as is.

MV-GH · 2025-02-18T23:15:20Z

I cant reproduce those crashes anymore. So that is good

dessalines · 2025-02-19T16:05:25Z

I still need to do a lot of testing on comment creation / updating, because how we're passing data using the navcontroller, is still an issue since this switches to a list-detail view for the home screen, where the panes are no longer their own nav route.

MV-GH · 2025-06-15T12:30:49Z

Hey, I recently discovered https://android-developers.googleblog.com/2025/05/announcing-jetpack-navigation-3-for-compose.html

They are building a new navigation lib, this one should have better support for adaptive layouts. But its still in Alpha, so we definitely need to wait until we get a stable release to try it out.

dessalines · 2025-06-15T14:13:29Z

Perfect. Yep these navigation problems when dealing with panes vs screens need to get handled upstream.

dessalines · 2026-06-17T23:13:49Z

Resurrecting this finally. The new non-alpha dep updates for adaptive layouts seemed to fix all the issues we had with navigation.

Since there are a lot of changes here, I'd like the 1.0 updates to come after this.

MV-GH · 2026-06-21T16:13:02Z

The adaptive navigation bar has odd behaviour with with our custom navigation options (hide / smaller with no text)

dessalines · 2026-06-21T16:42:39Z

The show_text_descriptions seems to be working okay, but yes the hide navigation bar setting doesn't work.

All these vital locations (like inbox, reports, etc) don't exist anywhere else in the UI, so maybe I should just remove that setting, or hide it for now.

MV-GH · 2026-06-21T16:50:45Z

they do exist in the hamburger menu when its hidden from the navigation rail

dessalines added 2 commits November 20, 2024 10:16

Getting multi-pane home working.

09b507c

Adding navigation bar scaffold.

fbecf47

dessalines changed the title ~~Getting multi-pane home working.~~ Adding tablet UI for home Nov 20, 2024

dessalines marked this pull request as ready for review November 20, 2024 16:25

dessalines requested a review from MV-GH as a code owner November 20, 2024 16:25

dessalines commented Nov 20, 2024

View reviewed changes

Fixing back button.

78b4915

MV-GH reviewed Nov 20, 2024

View reviewed changes

Comment thread app/build.gradle.kts Outdated

MV-GH reviewed Nov 20, 2024

View reviewed changes

Comment thread app/build.gradle.kts Outdated

MV-GH reviewed Nov 20, 2024

View reviewed changes

Comment thread app/src/main/java/com/jerboa/ui/components/common/AccountHelpers.kt Outdated

MV-GH reviewed Nov 20, 2024

View reviewed changes

dessalines added 2 commits November 20, 2024 16:51

Merge remote-tracking branch 'origin/main' into post_listing_detail_t…

7492570

…ablet

Updating to stable compose bom.

e6546cc

dessalines added 2 commits February 18, 2025 16:39

Merge remote-tracking branch 'origin/main' into post_listing_detail_t…

fe47f61

…ablet

Fixing JDK crash.

7c846c2

MV-GH reviewed Feb 18, 2025

View reviewed changes

Addressing PR comments

17828a0

dessalines marked this pull request as draft February 19, 2025 16:02

dessalines added 2 commits June 11, 2026 17:51

Merge branch 'main' into post_listing_detail_tablet_merge_1

9f2f300

Some mis-merges

fd24493

dessalines marked this pull request as ready for review June 17, 2026 23:12

Fixing deps

22968dc

dessalines requested a review from MV-GH June 17, 2026 23:13

Uh oh!

Conversation

dessalines commented Nov 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MV-GH commented Nov 20, 2024

Uh oh!

dessalines commented Nov 20, 2024

Uh oh!

MV-GH commented Nov 26, 2024

Uh oh!

MV-GH commented Nov 26, 2024

Uh oh!

dessalines commented Nov 27, 2024

Uh oh!

MV-GH commented Feb 13, 2025

Uh oh!

dessalines commented Feb 18, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dessalines Feb 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MV-GH commented Feb 18, 2025

Uh oh!

dessalines commented Feb 19, 2025

Uh oh!

MV-GH commented Jun 15, 2025

Uh oh!

dessalines commented Jun 15, 2025

Uh oh!

dessalines commented Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MV-GH commented Jun 21, 2026

Uh oh!

dessalines commented Jun 21, 2026

Uh oh!

MV-GH commented Jun 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

dessalines commented Nov 20, 2024 •

edited

Loading

dessalines Feb 19, 2025 •

edited

Loading

dessalines commented Jun 17, 2026 •

edited

Loading