chore(deps): expand Renovate config + add version policy (Step 9)#133
Conversation
- renovate.json: add package groups (kotlin, androidx-test, kotest, ktor, screenshot-testing, static-analysis), tighten minor automerge to safe packages only, add oneui-design to ignoreDeps - CLAUDE.md: add Version Policy section documenting the lockstep rules, exception classes, and manual lint-before-push reminder Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Warning Review limit reached
Your plan currently allows 1 review/hour. Refill in 54 minutes and 16 seconds. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more review capacity refills, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time. Please see our FAQ for further information. WalkthroughThis PR updates build configuration and dependency management across four files. The Gradle version catalog is refactored to rename the Android Gradle Plugin version key from ChangesBuild and dependency management updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive version policy in CLAUDE.md and refines the Renovate configuration by organizing dependencies into logical groups and defining specific automerge rules. Review feedback suggests moving platform-native automerge settings to the top level for better consistency and expanding the list of packages eligible for minor automerge to ensure that grouped updates are not blocked.
- Stop ignoring `common-utils` and `oneui-design` dependencies - Enable global `platformAutomerge` - Expand automerge rules to include `android-junit`, `hilt.android`, and all `kotlinx-coroutines` modules - Update `CLAUDE.md` to reflect that private dependencies are no longer manually managed
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the project's version policy in CLAUDE.md, renames the Gradle version reference to 'agp' for clarity in the libs.versions.toml file, and significantly restructures the Renovate configuration. The Renovate changes include enabling platform automerge and defining specific package groups and automerge rules for various dependencies. Feedback was provided regarding the accidental removal of the 'ignoreDeps' block in renovate.json, which is necessary to prevent Renovate from failing when attempting to fetch private dependencies from public registries.
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
renovate.json (1)
1-88:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winAdd missing
ignoreDepsforio.github.tribalfs:oneui-design.
renovate.jsonhas noignoreDepsentry, so Renovate will keep proposing updates forio.github.tribalfs:oneui-design.Proposed fix
{ "$schema": "https://docs.renovatebot.com/renovate-schema.json", "extends": [ "config:recommended", ":disableDependencyDashboard", ":renovatePrefix", ":configMigration" ], "platformAutomerge": true, + "ignoreDeps": [ + "io.github.tribalfs:oneui-design" + ], "packageRules": [🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@renovate.json` around lines 1 - 88, Add a top-level ignoreDeps entry for the package so Renovate stops proposing updates for io.github.tribalfs:oneui-design; specifically, in renovate.json add "ignoreDeps": ["io.github.tribalfs:oneui-design"] (using the exact group:artifact string) alongside the existing keys (e.g., next to "$schema" / "extends" / "packageRules") so the resolver will skip that dependency.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ci.yml:
- Line 35: Replace the loose tag reference "uses: actions/upload-artifact@v7"
with the exact commit SHA that v7 currently resolves to (use "uses:
actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a") in every
occurrence (the two places where "actions/upload-artifact@v7" appears) to pin
the action to that specific commit and improve supply-chain integrity.
---
Outside diff comments:
In `@renovate.json`:
- Around line 1-88: Add a top-level ignoreDeps entry for the package so Renovate
stops proposing updates for io.github.tribalfs:oneui-design; specifically, in
renovate.json add "ignoreDeps": ["io.github.tribalfs:oneui-design"] (using the
exact group:artifact string) alongside the existing keys (e.g., next to
"$schema" / "extends" / "packageRules") so the resolver will skip that
dependency.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 948d9868-c556-45ef-bc90-ff9716dbb9c8
📒 Files selected for processing (4)
.github/workflows/ci.ymlCLAUDE.mdgradle/libs.versions.tomlrenovate.json
Summary
kotlin,androidx-test,kotest,ktor,screenshot-testing,static-analysisgroups; tightens minor automerge to safe packages only (patch+digest still automerge for all); addsoneui-designtoignoreDepslintDebug-before-push reminderTest Plan
🤖 Generated with Claude Code
Summary by CodeRabbit