Improve extra item aura refresh timing for fishing buffs#32
Conversation
|
@LegolandoBloom Can you please review and merge? |
|
I added the new file and manually merged in the few changes for retail. This update does work better, so thanks for that :) But... it still wasn't perfect. Eventually, I ran into a scenario like this (counts down to the end of the buff)... (in my experience, it seems that if you start out with a buff, and it expires before the catch, the catch does not benefit from the buff.) Honestly, the way I expected the timer to work is that it just keeps track of the last time it threw a fish in. So if I manually throw a bunch in to get 3 minutes buff and start fishing, the next cast with less than 2m30s (being longer than my 30s timer setting) would throw in a fish to get me back to ~3 minutes. Eventually, that would also run out of buff time unless the tracker also applies the deltas each time. |
|
By the way, this PR is never going to be accepted per this comment: #29 (comment) |
Summary
This PR updates extra item and macro aura refresh behavior so Angleur can reapply before the buff fully expires, using fishing channel timing instead of waiting for aura removal.
Closes #30.
Changes
UnitChannelInfo("player")and use that as the preferred refresh threshold30second threshold when no live fishing channel duration is availableValidation
luaorluajitruntime is available onPATH