fix: wrap FilenameIndex lookups in ReadAction to fix read-access crash on newer IDEs#98
Open
wowkin2 wants to merge 1 commit into
Open
fix: wrap FilenameIndex lookups in ReadAction to fix read-access crash on newer IDEs#98wowkin2 wants to merge 1 commit into
wowkin2 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #97
On newer IntelliJ platforms the EDT no longer holds an implicit read lock, and
SlowOperations.allowSlowOperations()does not grant read access.Calling
FilenameIndex.getVirtualFilesByName()from the UI thread therefore throws:"Read access is allowed from inside read-action only".Wrap the index lookups in
ReadAction.compute(...), matching the existing pattern inStateManager, so navigation works on both old and new platforms.