🔒 [security fix] Use immutable PendingIntent without redundant update flag#48
Conversation
Removed FLAG_UPDATE_CURRENT from PendingIntent creations in AwidgetProvider.kt to follow security best practices for immutable intents.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: Removed the redundant
⚠️ Risk: Using
FLAG_UPDATE_CURRENTfromPendingIntentcreations inAwidgetProvider.kt.FLAG_UPDATE_CURRENTwhen not needed is a minor security concern; specifying onlyFLAG_IMMUTABLEis the preferred best practice for Android 12+ (API 31+) to reduce the attack surface ofPendingIntents.🛡️ Solution: Updated all 14 occurrences in
AwidgetProvider.ktto use onlyFLAG_IMMUTABLE, as none of these intents (alarms, widget clicks, settings shortcuts) rely on updating extras after thePendingIntentis first created.PR created automatically by Jules for task 8744115456617007643 started by @LeanBitLab