Skip to content

Changed deploy strategy to use the config of the branch being deployed - #10

Open
jacob-s-son wants to merge 1 commit into
masterfrom
branch-deploy-config
Open

Changed deploy strategy to use the config of the branch being deployed#10
jacob-s-son wants to merge 1 commit into
masterfrom
branch-deploy-config

Conversation

@jacob-s-son

Copy link
Copy Markdown

I am not sure though where it's fetching repo. This obviously won't work if jarvis copy of the repo is not aware of the new branch.

@RadekMolenda

Copy link
Copy Markdown

👍

@benflex

benflex commented Sep 18, 2014

Copy link
Copy Markdown
Contributor

What if you do a git fetch and then git checkout for the branch ?
i.e.
cmd += "git fech; git checkout #{params[:branch]}"

@jacob-s-son

Copy link
Copy Markdown
Author

That's an option. Will update.

@pointlessone

Copy link
Copy Markdown
git fetch && git checkout

Is probably better.

@jacob-s-son

Copy link
Copy Markdown
Author

But git pull is still needed right, as non of those is going to merge ?

@benflex

benflex commented Sep 18, 2014

Copy link
Copy Markdown
Contributor

No sure why we would need to merge since no work is gonna be done ever on the server ? This probably needs to be tested.

@benflex

benflex commented Sep 18, 2014

Copy link
Copy Markdown
Contributor

Or we can do :
cmd += "git fetch; git checkout #{params[:branch]} && git pull origin #{params[:branch]}"

@jacob-s-son

Copy link
Copy Markdown
Author

I have tried out locally simply fetch + checkout, works fine if you simply updating outdated repo and switch to a branch, that is not merging anything.

I think let's go with @cheba proposed git fetch && git checkout params[:branch]

WDYT?

@benflex

benflex commented Sep 18, 2014

Copy link
Copy Markdown
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants