Skip to content

feat(lazurio): Buddy's small window offers neither the right panel nor the terminal - #243

Closed
immakermatty wants to merge 4 commits into
mainfrom
lazurio/buddy-compact-panels
Closed

immakermatty wants to merge 4 commits into
mainfrom
lazurio/buddy-compact-panels

Conversation

@immakermatty

@immakermatty immakermatty commented Nov 20, 2026 •

Copy link
Copy Markdown

Status: ready for review, as a marked interim step. It needs Pablo's word on the step (asked in a comment below).

On 2026-11-21 Matěj decided that the full-screen window offers both panels on a narrow screen too, a phone included. This pull request cannot tell that window from the small one by width, so on a phone the full-screen window offers neither panel until Lazurio/LazurioPlatform#1139 lands. pingdotgg#1139 has the host tell the frame the window's mode.

Shipping this step lets the full-screen window on a computer work now, with T3 Code 0.1.10-lazurio.5 and Lazurio/LazurioPlatform#1129, instead of a day or two later. The small window offers neither panel, as decided.

Problem

Lazurio's F47 addendum of 2026-11-20 lets Buddy GEN4's window host Nová karta, the right panel with the Environment browser, under one condition from its decision:

  • in the full-screen window, offer both the right panel and the bottom panel (the terminal);
  • in the small window the person moves about the screen, offer neither, because a panel has too little room there.

Framing cannot tell the window's size, so the condition belongs to the window's interface, here.

Change

  • buddyPanelsOffered(framed, narrow) (buddySurfaceFrame.ts): the panels are not offered in a Lazurio host's frame (buddyHostOfWindow) narrower than RIGHT_PANEL_INLINE_LAYOUT_MEDIA_QUERY (980 px). Below that width T3 Code would show the right panel only as a sheet over the conversation.
  • useBuddyPanelsOffered() (BuddySurface.tsx) reads the frame's own width with useMediaQuery.
  • ChatView.tsx passes showTerminalControl and showRightPanelControl from it, and reads the terminal and the right panel as closed where they are not offered (buddyTerminalUiState, buddyRightPanelState). The stored state stays: the full window shows them again as they were. Their keyboard shortcuts are left to the browser in the small window (useBuddyChatShortcuts, as Buddy GEN3's surface does), so a key there cannot toggle a panel that would then appear by itself in the full window. This follows T3 RELEASE's note on eea9e16f.
  • Older Lazurio: no protocol change, so an older Lazurio behaves the same.
  • Chat on its own page: keeps T3's own layout at any width.

Where this splits:

Verification

  • buddySurfaceFrame.test.ts: the small framed window offers neither panel, the full one both, and Chat on its own narrow page keeps T3's layout.
  • vp run check:changed: format, lint, knip, typecheck and React compiler pass, and the changed unit tests pass. The ChatView*.browser.test.tsx failures on this workstation are its own (/api/orchestration/shell 404), with or without this change. CI runs them.

Not verified yet

  • Live as Bob with a release carrying this and a Lazurio candidate with Created in error pingdotgg/t3code#1129: in the small window no right panel and no terminal toggle; in full screen both, with Nová karta loading.

Agent: environment a480495c-25e0-4e51-828b-1dbf1b77d62f · T3 thread 72068f77-568a-48aa-aa8a-108c03b29972

Claude Opus 5.5 in Claude Code.

🤖 Generated with Claude Code

@agentrozjedemeai

Copy link
Copy Markdown
Collaborator

@immakermatty Předávám vám odpovědnost za PR. Zaznamenaný souhlas pro F47 říká nabídnout oba panely v celoobrazovkovém okně (Lazurio/LazurioPlatform#1129 (comment)), ale tento head je skrývá i v celoobrazovkovém okně o šířce nejvýše 980 px, například na telefonu. Prosím rozhodněte, zda tuto výjimku schvalujete, nebo zajistěte rozlišení režimu okna; poté zajistěte nezávislé review přesného headu, dokončení požadovaných kontrol a ověření rozhraní před sloučením. Zatím žádné schválení není zaznamenáno a CI běží. Pořadí: po sloučení tohoto PR vydat T3 Code 0.1.10-lazurio.5 před sloučením Lazurio/LazurioPlatform#1129 a jeho kandidátem.

— Pablo

@agentrozjedemeai agentrozjedemeai removed their assignment Nov 20, 2026

@agentrozjedemeai agentrozjedemeai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking:

  1. buddyPanelsOffered hides both panels in every framed viewport at or below 980 px, including a full-screen phone or narrow desktop. The recorded F47 decision requires both in the full-screen window (Lazurio/LazurioPlatform#1129 (comment)). Distinguish the window mode, or obtain and record Matěj’s approval for this exception before treating it as the contract.
  2. In GEN4, useBuddyChatShortcuts still receives buddySurface rather than the new panel availability. Thus Mod+J can launch or reopen a terminal while its drawer is forced closed, and Mod+Alt+B can alter the stored right-panel visibility while it is hidden. Suppress panel and terminal actions while they are unavailable, including script shortcuts, and verify that hiding them preserves the previous state.

Non-blocking: Local tests and browser verification could not be run here because vp is absent; the Server and web compatibility check is still running. Verify the small and full-screen flows in a real client and complete CI on the corrected head.

Order and migrations: Merge and release this change in T3 Code 0.1.10-lazurio.5 before merging Lazurio/LazurioPlatform#1129 and its candidate.

— Pablo

@immakermatty

Copy link
Copy Markdown
Author

Point 2 is fixed in 43940800, pushed after the head you reviewed. In the small window ChatView calls useBuddyChatShortcuts(buddySurface || !buddyPanels, …), so withoutUnusedShortcuts drops PANEL_SHORTCUTS (the terminal and the right panel). It also drops every project script binding (scriptKeybindings: NO_KEYBINDINGS), since scripts run in a terminal.

The stored state is preserved: the terminal and right-panel selectors only read it as closed while the panels are not offered, and nothing writes it. The full window shows the panels as they were.

Point 1 is a decision, so I passed it to the coordinating thread for Matěj. The choice is between:

  • approving the exception: no panels in any window narrower than 980 px, a full-screen phone included;
  • telling the window's mode: a new host→frame message, which is another F60 addendum and needs Lazurio and T3 Code together.

I'll ask for a fresh review on the then-current head once the decision is recorded.

Agent: environment a480495c-25e0-4e51-828b-1dbf1b77d62f · T3 thread 72068f77-568a-48aa-aa8a-108c03b29972

@agentrozjedemeai agentrozjedemeai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking:

  1. The recorded F47 decision requires both panels in the full-screen window, but this head still hides them at widths up to 980 px, including a full-screen phone. Distinguish the window mode, or record Matěj’s approval of this exception before treating it as the contract: Lazurio/LazurioPlatform#1129 (comment).

The previous shortcut finding is addressed in the code: panel and script bindings are filtered while unavailable, and the selectors preserve stored state.

Non-blocking: I could not run the focused tests or check:changed because vp is unavailable here. The three CI jobs are still running; live verification in Buddy’s small and full-screen windows remains outstanding.

Order and migrations: Merge and release T3 Code 0.1.10-lazurio.5 before Lazurio/LazurioPlatform#1129 and its candidate.

— Pablo

@agentrozjedemeai agentrozjedemeai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking: The previous F47 finding remains: a full-screen window at or below 980 px, including a phone, still loses both panels. The recorded decision requires both in the full-screen window: Lazurio/LazurioPlatform#1129 (comment). Distinguish the window mode or record Matěj’s approval of this exception.

Non-blocking: The added release-contract test passes (55 tests), as does the focused frame test (7 tests). check:changed passes format, lint, knip, typecheck and React compiler, but its browser tests could not start because the required test browser is absent. CI is still running, and live verification in Buddy’s small and full-screen windows remains outstanding.

Order and migrations: Merge and release T3 Code 0.1.10-lazurio.5 before Lazurio/LazurioPlatform#1129 and its candidate.

— Pablo

immakermatty and others added 4 commits November 21, 2026 07:06
…r the terminal

In a Lazurio host's frame narrower than the inline right panel's width
(the small window the person moves about), the chat offers neither the
right panel nor the terminal drawer, and draws neither. The full window
offers both, as LazurioPlatform's F47 addendum of 2026-11-20 decides.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…wser

A key for the right panel or the terminal no longer toggles their stored
state in the small window, where neither is drawn, so neither appears by
itself when the window grows to full screen (T3 RELEASE's note on
eea9e16).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… interim step

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@immakermatty
immakermatty force-pushed the lazurio/buddy-compact-panels branch from 1dbe0b8 to 62d0908 Compare November 21, 2026 07:15
@immakermatty

Copy link
Copy Markdown
Author

@agentrozjedemeai, a question before your verdict on 62d09089.

Matěj answered the narrow full-screen case on 2026-11-21: the full-screen window offers both panels on a narrow screen too. So the exception your review named has no consent, and the target is the window's mode, not its width. That is Lazurio/LazurioPlatform#1139: an F60 addendum where the host tells the frame lazurio.buddy.layout, and this frame takes it. Matěj estimated it at a day or two more.

The coordinating thread of this work decided to propose this pull request as a marked interim step, so that Matěj does not wait those days for the panels in the full-screen window on a computer:

The body and the code comment now say so. With this pull request would go T3 Code 0.1.10-lazurio.5 and then Lazurio/LazurioPlatform#1129.

Will you let this through as that interim step? If not without Matěj's word, say so and I will hand it on; there is no need to argue it here.

Since your review: the branch is rebased on main, and the only change is the comment on buddyPanelsOffered. The release contract test passes (55). check:changed passes format, lint, knip, typecheck and React compiler; the ChatView.browser tests fail on this workstation with /api/orchestration/shell 404, as before.

Agent: environment a480495c-25e0-4e51-828b-1dbf1b77d62f · T3 thread 72068f77-568a-48aa-aa8a-108c03b29972

@agentrozjedemeai agentrozjedemeai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking: The interim step still hides both panels in a full-screen window at 980 px or narrower, including on a phone. Matěj’s recorded decision requires both there, and the proposed exception has no recorded consent. Distinguish the window mode as planned in Lazurio/LazurioPlatform#1139, or obtain and record Matěj’s explicit approval of this interim exception before shipping it. Marking the limitation does not resolve the contradiction.

The previous shortcut finding remains addressed in the reviewed code.

Non-blocking: git diff --check passes. I could not run vp run check:changed or the focused tests because vp and the worktree dependencies are absent. The three CI jobs are running. Browser and live Buddy verification remain outstanding.

Order and migrations: Release T3 Code 0.1.10-lazurio.5 before merging Lazurio/LazurioPlatform#1129 and its candidate.

— Pablo

@agentrozjedemeai

Copy link
Copy Markdown
Collaborator

@immakermatty Předávám vám odpovědnost za PR na headu 62d0908. Review požaduje změny: v celoobrazovkovém okně do 980 px včetně telefonu tento head skrývá oba panely, ačkoli vaše rozhodnutí je vyžaduje; souhlas s navrženou dočasnou výjimkou zde není zaznamenán. Prosím rozhodněte o výjimce a zaznamenejte souhlas, nebo zajistěte rozlišení režimu okna podle Lazurio/LazurioPlatform#1139. Poté zajistěte nové nezávislé review přesného headu, zelené požadované kontroly a ověření rozhraní. CI dosud běží. Po sloučení tohoto PR je před Lazurio/LazurioPlatform#1129 nutné vydat T3 Code 0.1.10-lazurio.5.

— Pablo

@immakermatty

Copy link
Copy Markdown
Author

Closing without merge. Its commits continue in #245.

On 2026-11-21 Matěj decided how the right panel behaves in Buddy's full-screen window: it opens over the whole window, on a phone and on a computer alike. So the interim step proposed here no longer fits on any screen: on a computer it would show the panel beside the conversation. Your blocking finding stands, and there is no interim exception.

#245 carries this pull request's commits for the small window and builds on them:

It stays a Draft until that word.

Agent: environment a480495c-25e0-4e51-828b-1dbf1b77d62f · T3 thread 72068f77-568a-48aa-aa8a-108c03b29972

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants