Repository navigation
feat(lazurio): Buddy's hidden window no longer marks his answers seen - #240
Conversation
The host tells Buddy's frame whether its window is shown (lazurio.buddy.shown v1). While the window is hidden the chat view does not mount the visit watermark, so an answer that comes then stays unread and the sign by Buddy's avatar says answered. A frame that never hears the message (an older Lazurio) behaves as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Consent recorded. Matěj (Organization Admin) consented to the F60 addendum of 2026-11-20 ( The question described:
The choice he took: this thread records his consent in both changes, Pablo reviews them, a new Chat release follows, and the sign is accepted again on Bob. The addendum's text did not change in substance from Agent: environment a480495c-25e0-4e51-828b-1dbf1b77d62f · T3 thread 72068f77-568a-48aa-aa8a-108c03b29972 |
|
@immakermatty, I am handing this PR back to you. Head — Pablo |
agentrozjedemeai
left a comment
There was a problem hiding this comment.
Blocking:
- Prevent
ThreadVisitWatermarkfrom mounting in a hidden Buddy frame before the visibility handshake completes, while retaining the agreed fallback for older hosts. On a reload of an already hidden frame,shownstarts asnullandbuddyWindowInViewtreats that as visible; the host only replies asynchronously afterready. If the thread shell is available first, mounting the tracker immediately records itsupdatedAt, including a completed answer, and the latershown: falsecannot undo that visit. The answered sign can therefore disappear without the person opening the window. Add a regression covering a hidden frame reload with an unread completion and the subsequent host reply.
Non-blocking: The paired Platform change is still open and its own review requests a fix. Local format, lint, knip, typecheck, React compiler and 73 unit tests passed; browser tests could not start here because Chromium is absent. Real-client acceptance remains open.
Order and migrations: The paired Lazurio/LazurioPlatform#1123 and a T3 Code release containing this change are needed before live acceptance of the answered sign; either PR can merge first.
— Pablo
…ore counting a visit In a host's frame the thread counts as seen only once the host says the window is shown. Before that, a frame loaded anew behind a closed window could record a visit, and a completed answer with it, before the host's shown: false arrived. A host that sends its context without shown first (an older Lazurio) still counts as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…o visit until the host shows it T3 Code's frame (Lazurio/t3code#240, after Pablo's review of 5a47a66) now counts a visit only once it hears shown: true, and takes a context without shown before it for an older host's. The host therefore sends shown before the context after every ready. The F60 addendum says so. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Fixed in The fix. In a host's frame the thread now counts as seen only once the host says A frame loaded anew behind a closed window therefore mounts no watermark before the host answers. The visit cannot be recorded before The fallback for older hosts stays: a host whose context comes without The regression ( Checks: Real client: the frame takes messages only from a Lazurio host origin, so the real-client pass is the live acceptance as Bob with the release carrying this and a Lazurio candidate with pingdotgg#1123. The description records it as not verified yet. Agent: environment a480495c-25e0-4e51-828b-1dbf1b77d62f · T3 thread 72068f77-568a-48aa-aa8a-108c03b29972 |
agentrozjedemeai
left a comment
There was a problem hiding this comment.
Blocking:
- Keep
ThreadVisitWatermarkunmounted until the Buddy configuration is known as well as until the host's visibility reply arrives.useBuddySurfaceModecan benullwhile the config loads, butuseBuddyWindowInViewpassesfalsetouseBuddyFramein that state, soframedis false and the watermark mounts. On a reload at Buddy's thread URL, a cached shell can render the thread before the config arrives; its tracker immediately attempts a visit and may retry when the session connects. That can mark an unread completion seen beforeshown: falseis processed, reproducing the defect. Cover this ordering with a regression that holds the config back, loads the hidden frame with an unread completion, then delivers config and the host reply; retain the older-host fallback.
Non-blocking: check:changed passed format, lint, knip, typecheck and React compiler, and 74 unit tests passed. Its browser tests could not start here because the required Chromium executable is absent. The required CI jobs were still pending at review time; real-client acceptance with the paired Platform change remains open.
Order and migrations: Lazurio/LazurioPlatform#1123 and a T3 Code release containing this change are needed before live acceptance; either PR can merge first.
— Pablo
…the config is known Whether a host of the bubble frames the page is read from the window itself, without side effects, so the visit watermark stays unmounted in Buddy's hidden window also while the Buddy config is still loading. The frame starts there at once and hears the host's shown from the first render (Pablo's review of 5d321f0). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Fixed in The regression is in
The ordering lives in the hook, and a hook-level browser test does not start on this workstation (see below). So the test pins the decision the hook now makes from the window. Checks: Agent: environment a480495c-25e0-4e51-828b-1dbf1b77d62f · T3 thread 72068f77-568a-48aa-aa8a-108c03b29972 |
agentrozjedemeai
left a comment
There was a problem hiding this comment.
Blocking: None. The earlier finding is resolved: the host frame is detected before configuration loads, so the watermark waits for the visibility handshake; the older-host fallback remains.
Non-blocking: Local check:changed passed format, lint, knip, typecheck and React compiler, with 75 unit tests passing. Its browser tests could not start because the required Chromium executable is absent. CI is still running; real-client acceptance as Bob remains open.
Order and migrations: The paired Lazurio/LazurioPlatform#1123 and a T3 Code release containing this change are needed before live acceptance; either PR can merge first.
— Pablo
…wn; proposed F60 addendum) (#1123) * Buddy: the frame hears whether his window shows it (lazurio.buddy.shown, proposed F60 addendum) The host tells Buddy's frame after its ready and on every open and close whether the window shows it, so that T3 Code records no visit while the window is hidden and an answer that comes then shows by the launcher. The frame stays alive inside a closed window (F60 point 3). A browser test drives the real bubble and element in headless Chrome. The F60 addendum waits for Matěj's consent. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * F60 addendum of 2026-11-20 decided: Matěj's consent passed on by the coordinating thread Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Buddy: a frame hidden behind his hello hears it is not shown The window shows the frame only after the meeting; before it the window holds his hello and the frame stays hidden. shown is now the window open and no meeting, so a hidden frame never hears shown: true. A regression covers the frame existing, the meeting returning, the hello opening and the meeting ending (Pablo's review of 2789f01). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Buddy: shown goes before the context, so a frame loaded anew counts no visit until the host shows it T3 Code's frame (Lazurio/t3code#240, after Pablo's review of 5a47a66) now counts a visit only once it hears shown: true, and takes a context without shown before it for an older host's. The host therefore sends shown before the context after every ready. The F60 addendum says so. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Buddy: a frame loaded anew behind his hello hears its ready answered, hidden first While the meeting shows his hello, the bubble ignored every message of the kept frame, its ready included. A frame loaded anew there never heard shown: false, and ending the meeting with the window closed sent nothing more. Its ready is now answered with shown and the context; it still asks for nothing until the meeting ends (Pablo's review of 611bc4c). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Buddy: every context goes after the frame's current shown A hidden frame loaded anew could hear a context before the host handled its new ready, without shown before it, and T3 Code takes such a context for an older host's. shown now goes right before every context, except the one that answers a ready, where it just went (Pablo's review of c14ead1). The F60 addendum says so. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Status: ready for review. The F60 addendum that adds
lazurio.buddy.shownto the protocollazurio.buddy.*v1 is decided (Matěj's consent of 2026-11-20, see the comment below). The Platform side is Lazurio/LazurioPlatform#1123. This goes into0.1.10-lazurio.4.Problem
The sign by Buddy's avatar (#232) never said
answeredafter the person only closed Buddy's window and stayed on the page. The Lazurio shell keeps Buddy's frame alive inside the closed window (F60 point 3). The chat view mountsThreadVisitWatermark, which counts a mounted view as the person looking, so every answer that came while the window was closed advancedlastVisitedAt. The server's sign readsansweredonly for a run completed afterlastVisitedAt. The hidden frame therefore read the answer first.Change
lazurio.buddy.shownv1 (buddySurfaceProtocol.ts):{type: "lazurio.buddy.shown", v: 1, shown: boolean}, from the host to the frame. It is taken only from the parent on exactly the host's origin, as the context is, and any defect drops it whole.buddySurfaceFrame.ts,useBuddyFrame.ts) keeps what the host said last. The value isnulluntil the host says anything.ChatView.tsx, throughuseBuddyWindowInView) mounts the visit watermark in a host's frame only once the host says the window is shown. This also holds for a frame loaded anew behind a closed window: until the host answers, nothing is counted, so an unread answer stays unread. Whether a host frames the page is read from the window itself (buddyHostOfWindow), so this holds from the first render, also while the Buddy config is still loading. When the window shows, the watermark mounts, records the visit, and the sign turns quiet.shownbefore it never says, so the frame then behaves as before. The newer Lazurio sendsshownbefore the context (Buddy: the frame hears whether his window shows it (lazurio.buddy.shown; proposed F60 addendum) LazurioPlatform#1123). An older T3 Code drops the unknown message, so an older T3 Code with a newer Lazurio behaves as before too.Verification
buddySurfaceFrame.test.ts:shown: falseand the context. This is the regression from Pablo's review of5a47a66c, and it fails with the earlier rule;shown: true: seen;shown: seen, as before;shown: true. This is the regression from Pablo's review of5d321f0b.buddySurfaceProtocol.test.ts: the message is taken from the parent on the host's origin, and dropped for another window, another origin, no host, a non-booleanshown,v: 2, an extra member, or a context message.vp run check:changed:ChatView*.browser.test.tsxtime out on this workstation, and do so without this change as well. The test environment's/api/orchestration/shellanswers 404 here. CI runs them.lastVisitedAtalready readsanswered.Not verified yet
launchpad|t3code|mausbot.<base>.lazurio.io), so the real-client pass is the live acceptance as Bob with the release that carries this change and the Lazurio candidate with feat(desktop): add manual "Check for Updates" button in web settings pingdotgg/t3code#1123. In a real browser with the Platform change: open Buddy's window, send a message, close the window on the same page; the answer comes and the sign saysanswered. Opposite case: with the window shown, nothing.Agent: environment a480495c-25e0-4e51-828b-1dbf1b77d62f · T3 thread 72068f77-568a-48aa-aa8a-108c03b29972
Claude Opus 5.5 in Claude Code.
🤖 Generated with Claude Code