[core] Fixes the issue when players get stuck in a BCNM when they disconnect during opening the chest.#10869
Conversation
|
This does look like it would fix the issue - however I would also recommend clearing the character variable on LEAVE_CODE_EXIT (player runs away from the battlefield) and inside of onEventFinishWin(by this point they should be outside) As its written it looks like if you leave the battlefield manually and then log out(outside, at the burning circle), you will get moved when you log in, which isnt quite correct. |
Clear battlefieldRecoveryId when a player leaves the arena under their own power. Every legitimate exit (running out, and leaving after a win or loss) routes through leavecode EXIT, so a player who leaves manually and then logs out at the burning circle is no longer wrongly ejected on relog. The disconnect teardown path uses WARPDC and keeps the marker, so a player who drops during the post-win loot window is still recovered.
Ah! you're right. Appreciate it. Just give you an update on my fixes and retested it |
I affirm:
What does this pull request do?
Fixes a case where a player is left permanently stuck inside a battlefield arena and cannot leave.
win a BCNM, open the loot chest, then disconnect before the ejection. On relog you are stranded in the arena, the exit does nothing, and the only way out is a warp item.
Steps to test these changes
Enter a BCNM
Defeat the battlefield and open the loot chest.
Force close the client before the ejection plays out.
Log back in.
on relog you are ejected to the battlefield exit within a few seconds.