Skip to content

[C++] [lua] [sql] Migrate Experience Points Calculations to LUA#10865

Open
Skold177 wants to merge 1 commit into
LandSandBoat:basefrom
Skold177:Experience-Points.lua
Open

[C++] [lua] [sql] Migrate Experience Points Calculations to LUA#10865
Skold177 wants to merge 1 commit into
LandSandBoat:basefrom
Skold177:Experience-Points.lua

Conversation

@Skold177

@Skold177 Skold177 commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

  • Migrates all experience points calculations into LUA (Referenced the JP Wiki and carefully copied over every function from core)
  • Moves base experience points table into LUA
  • Retires several experience points based settings, as this can all be easily changed now in modules.
  • Implements Sanction and leaves a TODO about its potency.

Testing Schedule - Complete! Tested and made sure everything was working on my local with debug prints using multiple clients.

[x] Party Share & Alliance Penalty
[x] Experience Points Chains (Brackets & Timers)
[x] Dedication Effects (EXP Rings)
[x] Corsairs Roll
[x] Signet Bonuses
[x] Sanction Bonuses
[x] RoV Bonuses

Steps to test these changes

Same as above!

@github-actions

Copy link
Copy Markdown

✨ Hello and thanks for the PR! ✨

🤖: This is a friendly automated reminder that the maintainers won't look at your PR until you've properly completed all of the checkboxes in the pre-filled template.

@Skold177
Skold177 force-pushed the Experience-Points.lua branch from 78ef5ad to b958b8d Compare July 23, 2026 02:19
@Skold177
Skold177 marked this pull request as ready for review July 23, 2026 03:22
@Skold177
Skold177 force-pushed the Experience-Points.lua branch 3 times, most recently from 62e07b1 to 1f4a34a Compare July 23, 2026 04:34
Migrates Experience Points Calculations to LUA and retires many experience points settings. Adds support for Sanction.
@Skold177
Skold177 force-pushed the Experience-Points.lua branch from 1f4a34a to a2d6ae3 Compare July 23, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant