[lua] Fix elegy potency bug#10855
Open
9001-Sols wants to merge 1 commit into
Open
Conversation
9001-Sols
marked this pull request as ready for review
July 24, 2026 22:06
Xaver-DaRed
reviewed
Jul 25, 2026
| power = power + utils.clamp(gearBoost - 1, 0, 20) + caster:getJobPointLevel(xi.jp.REQUIEM_EFFECT) * 3 | ||
| elseif spellEffect == xi.effect.ELEGY then | ||
| power = power + gearBoost * 6375 / 256 -- Simplified numbers of: 25.5 * 10000/1024 | ||
| power = power + gearBoost * 63750 / 256 -- Simplified numbers of: 25.5 * 10000/1024 |
Contributor
There was a problem hiding this comment.
power = power + math.floor(gearBoost * 25.6) * 10000 / 1024
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I affirm:
What does this pull request do?
Fixes Elegy potency gain from Song+ gear (
ELEGY_EFFECT/ALL_SONGS_EFFECT) being 10x too low.gearBoostwas multiplied by6375/256instead of63750/256. Elegy power feedsHASTE_MAGIC, which is in /10000 units, so per-point gear potency is25.5/1024 * 10000 ≈ 249.Steps to test these changes
Elegy +/All Songs +gear and recastTest Results
Before almost no perceivable effect, after matches BG wiki's +2 chart, as well as the original comment

-- Simplified numbers of: 25.5 * 10000/1024: