Skip to content

[LUA] Fix Better Part of Valor waterfall trigger#10818

Open
whiskeyhughes wants to merge 1 commit into
LandSandBoat:basefrom
whiskeyhughes:fix-better-part-of-valor-waterfall
Open

[LUA] Fix Better Part of Valor waterfall trigger#10818
whiskeyhughes wants to merge 1 commit into
LandSandBoat:basefrom
whiskeyhughes:fix-better-part-of-valor-waterfall

Conversation

@whiskeyhughes

Copy link
Copy Markdown
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Fixes the waterfall ??? interaction for the Bastok [S] quest Better Part of Valor.

The quest was binding event 3 to qm1, but the ??? at the documented waterfall coordinates in North Gustaberg [S] is qm3.

This changes the quest interaction binding from:

['qm1']

to:

['qm3']

No SQL changes are required because the correct qm3 entity already exists at the waterfall location.

Steps to test these changes

  1. Add the quest and set the character to the waterfall stage:

    !addquest 7 12
    !setquestvar <PlayerName> 7 12 Prog 1
    !pos -232 41 425 88
    
  2. Interact with the waterfall ???.

  3. Confirm event 3 begins.

  4. Complete the cutscene.

  5. Check the quest variable:

    !getquestvar <PlayerName> 7 12 Prog
    
  6. Confirm Prog advances to 2.

@Xaver-DaRed Xaver-DaRed added the hold On hold, pending further action/info label Jul 20, 2026
@Xaver-DaRed

Copy link
Copy Markdown
Contributor

On hold: This is byproduct of a shift with qm names that happened recently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hold On hold, pending further action/info

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants