Skip to content

[C++,lua] Play zone music after Chocobo music ends#10806

Open
Nobutadas wants to merge 1 commit into
LandSandBoat:basefrom
Nobutadas:chocobo-music
Open

[C++,lua] Play zone music after Chocobo music ends#10806
Nobutadas wants to merge 1 commit into
LandSandBoat:basefrom
Nobutadas:chocobo-music

Conversation

@Nobutadas

Copy link
Copy Markdown
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

There are two problems with Chocobo music.

  1. When renting from a city, Chocobo music begins before you zone. On retail the music update is sent on zone.
  2. When the Chocobo music ends (390 seconds) no music plays and it's silent. On retail it swaps back to zone music.

[C++] The music packet in slot 4 is always 0 unless you are mounted: the number depends if Chocobo mount or personal mount. Observed in captures.
[lua] A new 15 second tick is added that checks when the song has finished and puts it to the played and finished state. The tick timer resets on zone which is why it's 15 seconds.

Capture where I rented a Chocobo from the city, zoned a few times, and let the time ware out; mounted a raptor in the field and zoned and tried to let the time wear out (it didn't); and rented from a crag.
https://drive.google.com/file/d/1-V8DsCVWdCMvRxHsX5U1ZOuT9hk83mEB/view?usp=drive_link

Steps to test these changes

Get on a chocobo and let the song wear off after 390 seconds zone music should start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant