[C++,lua] Play zone music after Chocobo music ends#10806
Open
Nobutadas wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
There are two problems with Chocobo music.
[C++] The music packet in slot 4 is always 0 unless you are mounted: the number depends if Chocobo mount or personal mount. Observed in captures.
[lua] A new 15 second tick is added that checks when the song has finished and puts it to the played and finished state. The tick timer resets on zone which is why it's 15 seconds.
Capture where I rented a Chocobo from the city, zoned a few times, and let the time ware out; mounted a raptor in the field and zoned and tried to let the time wear out (it didn't); and rented from a crag.
https://drive.google.com/file/d/1-V8DsCVWdCMvRxHsX5U1ZOuT9hk83mEB/view?usp=drive_link
Steps to test these changes
Get on a chocobo and let the song wear off after 390 seconds zone music should start.