Skip to content

Converted RoE to quest framework#10731

Open
greentchristian-LSB wants to merge 2 commits into
LandSandBoat:basefrom
greentchristian-LSB:base
Open

Converted RoE to quest framework#10731
greentchristian-LSB wants to merge 2 commits into
LandSandBoat:basefrom
greentchristian-LSB:base

Conversation

@greentchristian-LSB

Copy link
Copy Markdown
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Moves the start of Records of Eminence out of NPC scripts into its own quest script, making it show up in the quest log as in retail. Detects if you have started the tutorial, playing the correct version of the CS. Removes a line that was present in each of the RoE NPCs that duplicated the reward message upon completing the quest. And enabled rewatching the CS with the Bastok Markets Melody Minstrel since the framework was already in place - building the other three Melody Minstrels scripts from scratch would probably count as scope creep for this fix.

Steps to test these changes

Local tests: Create a new character in any nation. Try talking to the RoE NPC to have them tell you to set First Step Forward. After setting First Step Forward, talk to the RoE NPC again and get the CS. Verified that selecting 'Walk Away' does not complete the quest on all 4 NPCs. Verified that you get the correct version of the CS depending on if you have spoken to Gulldago\Alaune\Selele prior to starting the CS. Eternal Flame only has one version of the CS. Verified that expanded RoE objectives are available after completing the CS. Quest appears under Completed -> Other Areas -> Records of Eminence upon completion. Sparks shop available upon completion. NPCs accept vouchers as trades, ensured they do not accept random junk.

Retail tests: Checked that simply having talked to Gulldago\Alaune\Selele is sufficient for shorter CS to play. Checked with Melody Minstrels and learned that replaying CS always shows the extended version, regardless of tutorial completion.

@greentchristian-LSB

Copy link
Copy Markdown
Contributor Author

If Lamepaue needs to be excluded from this PR because of the check, that's fine; as mentioned above, it was only included because she came up while I was searching RECORDS_OF_EMINENCE, and the framework for rewatching the CS was already present. The only changes I made to her script was to uncomment the lines related to RoE, filled in the placeholder values, and added a single line to make sure that rewatching the RoE CS would not immediately play Fetichism afterward since the RoE CS itself supplies option 1 when watching all the way through.

Reverts Lamepaue since uncommented code isn't passing automated checks upstream.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant