Skip to content

[lua] Remove duplicate QM logic from Zilart Kings QMs#10596

Merged
Xaver-DaRed merged 1 commit into
LandSandBoat:basefrom
sruon:qm_timers
Jul 25, 2026
Merged

[lua] Remove duplicate QM logic from Zilart Kings QMs#10596
Xaver-DaRed merged 1 commit into
LandSandBoat:basefrom
sruon:qm_timers

Conversation

@sruon

@sruon sruon commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Noticed when I captured Aspid that the QM came back 30s after kesu. Applying it to all of them.

aspid_2026-4-24_18_43.zip

Steps to test these changes

@sruon
sruon marked this pull request as draft July 11, 2026 02:47
@github-actions github-actions Bot added the stale label Jul 25, 2026
@sruon sruon changed the title [lua] Lower Zilart Kings QMs to retail 30s [lua] Remove duplicate QM logic from Zilart Kings QMs Jul 25, 2026
@sruon
sruon marked this pull request as ready for review July 25, 2026 07:24
@sruon

sruon commented Jul 25, 2026

Copy link
Copy Markdown
Contributor Author

After re-reviewing the QMs were already set to the correct timer but the NMs themselves had duplicate logic on a separate timer... so I just removed anything dealing with the QMs from the NM scripts since the QM scripts use the right function to handle showing/hiding the QM.

I renamed Fafnir and Behemoth QMs while I was at it and correctly a wrong !pos in the header for Fafnir.

@sruon sruon removed the stale label Jul 25, 2026
@LandSandBoat LandSandBoat deleted a comment from github-actions Bot Jul 25, 2026
@Xaver-DaRed
Xaver-DaRed merged commit 2949f26 into LandSandBoat:base Jul 25, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants