[lua][sql] Add Assault mission Golden Salvage#10580
Open
Lydya-nick77 wants to merge 1 commit into
Open
Conversation
Lydya-nick77
force-pushed
the
golden-savage-ilrusi-atoll
branch
from
July 10, 2026 19:26
2e0c59e to
4bc520e
Compare
Lydya-nick77
marked this pull request as draft
July 10, 2026 19:55
Lydya-nick77
force-pushed
the
golden-savage-ilrusi-atoll
branch
10 times, most recently
from
July 11, 2026 02:44
a3f75e8 to
6780cc6
Compare
Lydya-nick77
marked this pull request as ready for review
July 11, 2026 02:48
Xaver-DaRed
reviewed
Jul 11, 2026
Xaver-DaRed
reviewed
Jul 11, 2026
Xaver-DaRed
reviewed
Jul 11, 2026
Contributor
|
I understand the backstory behind the Cursed Chests being set as both NPC and mobs but having an entity ID exist in both tables is an absolute no no. If they participate in combat in any form or shape, they need to be coded as mobs from the get go. If you browse the codebase and look at Limbus, there should be multiple examples of Chests being interactable and turning into different models. |
Lydya-nick77
force-pushed
the
golden-savage-ilrusi-atoll
branch
3 times, most recently
from
July 11, 2026 20:21
e229a53 to
8ba1ab8
Compare
Author
|
Ok no more NPC and Mobs sharing ID and respawning. 1 NPC chest ID random from the mob's ID and 11 chest mobs. |
Lydya-nick77
force-pushed
the
golden-savage-ilrusi-atoll
branch
3 times, most recently
from
July 12, 2026 18:22
8912cd4 to
cfbfda6
Compare
Author
|
Everything is done. |
Lydya-nick77
force-pushed
the
golden-savage-ilrusi-atoll
branch
from
July 12, 2026 23:49
dd847d3 to
876e4ec
Compare
Xaver-DaRed
force-pushed
the
golden-savage-ilrusi-atoll
branch
2 times, most recently
from
July 18, 2026 15:44
a0dc345 to
d783d72
Compare
Co-Authored-By: Xaver-DaRed <Xaver-DaRed@users.noreply.github.com>
Xaver-DaRed
force-pushed
the
golden-savage-ilrusi-atoll
branch
from
July 18, 2026 15:47
d783d72 to
e675cd9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Implementation of the Assault mission Golden Salvage.
Video capture
https://1drv.ms/v/c/0e3505d4abae4162/IQAnax80BqBwRLjIcB6VuEkTAdNv1TF4LMwJMqolGKEdd7s?e=3u5brB
Captain capture
https://1drv.ms/u/c/0e3505d4abae4162/IQBQgRMDQIG6R57Jg6dyqThqAZCNnJwqJLCA9VSgjnBKdiY?e=GOfSbw
Steps to test these changes
Start the Golden Salvage Assault, 12 chests are spawned (11 mimic and 1 with the golden figurehead) and 8 fishes randomly in the zone. Once the correct chest has been opened, the rune of release and the ancient box spawn. Click the rune to exit and complete the Assault.