Skip to content

[lua][sql] Add Assault mission Golden Salvage#10580

Open
Lydya-nick77 wants to merge 1 commit into
LandSandBoat:basefrom
Lydya-nick77:golden-savage-ilrusi-atoll
Open

[lua][sql] Add Assault mission Golden Salvage#10580
Lydya-nick77 wants to merge 1 commit into
LandSandBoat:basefrom
Lydya-nick77:golden-savage-ilrusi-atoll

Conversation

@Lydya-nick77

@Lydya-nick77 Lydya-nick77 commented Jul 10, 2026

Copy link
Copy Markdown

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Implementation of the Assault mission Golden Salvage.

Steps to test these changes

Start the Golden Salvage Assault, 12 chests are spawned (11 mimic and 1 with the golden figurehead) and 8 fishes randomly in the zone. Once the correct chest has been opened, the rune of release and the ancient box spawn. Click the rune to exit and complete the Assault.

@Lydya-nick77
Lydya-nick77 force-pushed the golden-savage-ilrusi-atoll branch from 2e0c59e to 4bc520e Compare July 10, 2026 19:26
@Lydya-nick77
Lydya-nick77 marked this pull request as draft July 10, 2026 19:55
@Lydya-nick77
Lydya-nick77 force-pushed the golden-savage-ilrusi-atoll branch 10 times, most recently from a3f75e8 to 6780cc6 Compare July 11, 2026 02:44
@Lydya-nick77
Lydya-nick77 marked this pull request as ready for review July 11, 2026 02:48
Comment thread scripts/zones/Ilrusi_Atoll/mobs/Cursed_Chest.lua
Comment thread scripts/zones/Ilrusi_Atoll/instances/golden_salvage.lua Outdated
Comment thread scripts/zones/Ilrusi_Atoll/IDs.lua Outdated
@Xaver-DaRed Xaver-DaRed added the hold On hold, pending further action/info label Jul 11, 2026
@sruon

sruon commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

I understand the backstory behind the Cursed Chests being set as both NPC and mobs but having an entity ID exist in both tables is an absolute no no. If they participate in combat in any form or shape, they need to be coded as mobs from the get go.

If you browse the codebase and look at Limbus, there should be multiple examples of Chests being interactable and turning into different models.

@Lydya-nick77
Lydya-nick77 force-pushed the golden-savage-ilrusi-atoll branch 3 times, most recently from e229a53 to 8ba1ab8 Compare July 11, 2026 20:21
@Lydya-nick77

Copy link
Copy Markdown
Author

Ok no more NPC and Mobs sharing ID and respawning. 1 NPC chest ID random from the mob's ID and 11 chest mobs.
I cleaned some IDs and reused some function from utils.

@Lydya-nick77
Lydya-nick77 force-pushed the golden-savage-ilrusi-atoll branch 3 times, most recently from 8912cd4 to cfbfda6 Compare July 12, 2026 18:22
@Lydya-nick77

Copy link
Copy Markdown
Author

Everything is done.

@Lydya-nick77 Lydya-nick77 changed the title [lua][cpp][sql] Add Assault mission Golden Salvage [lua][sql] Add Assault mission Golden Salvage Jul 12, 2026
@Lydya-nick77
Lydya-nick77 force-pushed the golden-savage-ilrusi-atoll branch from dd847d3 to 876e4ec Compare July 12, 2026 23:49
@Xaver-DaRed
Xaver-DaRed force-pushed the golden-savage-ilrusi-atoll branch 2 times, most recently from a0dc345 to d783d72 Compare July 18, 2026 15:44
Co-Authored-By: Xaver-DaRed <Xaver-DaRed@users.noreply.github.com>
@Xaver-DaRed
Xaver-DaRed force-pushed the golden-savage-ilrusi-atoll branch from d783d72 to e675cd9 Compare July 18, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hold On hold, pending further action/info

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants