Conversation
Commit 66aa348 cherry-picked the internal gcc/libstdc++ toolchain config into the public repo, which ships a libc++-built LLVM. Restore the clang++/libc++ flags, -fno-rtti/-fno-exceptions, and drop the stdc++fs link that has no libstdc++fs in this toolchain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The public repo ships a libc++-built LLVM in
extern/llvm-project, but commit66aa348cherry-picked the internal gcc/libstdc++ toolchain config into the public tree, which breaks the build (unable to find library -lstdc++fs).What this does
-stdlib=libc++(Makefile + CMake).-fno-rtti -fno-exceptionsto match the prebuilt LLVM (with-frtti -fexceptionson the bison-generated parser andchoreodriver, which require them).stdc++fslink (libc++ providesstd::filesystemnatively;libstdc++fsis neither present nor ABI-compatible).Test plan
make test-debugbuilds and runs green with this applied. The MARA B1 fence PR (#18) depends on this to build.