Skip to content

fix(security): replace adm-zip with node-stream-zip (CVE-2026-76845) [TE-27044] #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amathur-LT merged 2 commits into from
Sep 7, 2026
Merged

fix(security): replace adm-zip with node-stream-zip (CVE-2026-76845) [TE-27044] #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d1dd59
fix(security): replace adm-zip with node-stream-zip for tunnel binary…
rachit-lambdatest Sep 3, 2026
2137511
chore(release): bump version to 4.0.13
rachit-lambdatest Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 23 additions & 17 deletions lib/tunnel_binary.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ var localTunnelConfig_ = require('./cfg/node-tunnel-config-v3-latest.json'),
urlParse = require('url'),
HttpsProxyAgent = require('https-proxy-agent'),
util = require('./util'),
AdmZip = require('adm-zip'),
StreamZip = require('node-stream-zip'),
fs = require('fs'),
path = require('path'),
os = require('os'),
Expand Down Expand Up @@ -138,23 +138,29 @@ function TunnelBinary(httpTunnelConfig, options) {
var destBinaryPath = path.join(destParentDir, destBinaryName);
// Reading and Unzipping binary zip File
console.log(`Extracting binary`);
try {
var zip = new AdmZip(binaryPath);
zip.extractAllTo(destParentDir, false);
fs.chmod(destBinaryPath, '0755', function() {
return fnCallback(destBinaryPath)
var zip = new StreamZip.async({ file: binaryPath });
zip
.extract(null, path.resolve(destParentDir))
.then(function() {
return zip.close();
})
.then(function() {
fs.chmod(destBinaryPath, '0755', function() {
return fnCallback(destBinaryPath);
});
})
.catch(function(e) {
zip.close().catch(function() {});
console.log('Error log ------> ', e);
logger.log(
conf['user'],
conf['key'],
{ filename: __filename },
conf,
'Got Error while unzip downloading binary' + e
);
self.retryBinaryDownload_(conf, destParentDir, retries, binaryPath, fnCallback);
});
} catch (e) {
console.log("Error log ------> ", e);
logger.log(
conf['user'],
conf['key'],
{ filename: __filename },
conf,
'Got Error while unzip downloading binary' + e
);
self.retryBinaryDownload_(conf, destParentDir, retries, binaryPath, fnCallback);
}
} else {
console.error('Got Error while downloading binary zip');
logger.log(
Expand Down
Loading