fix(experiments): reject scriptless runs - #3
Open
jkoelker wants to merge 2 commits into
Open
Conversation
Commit 07e60be changed every new experiment to queue automatically while leaving script_content optional. That admitted queued records with no runnable script and no API path for attaching one later. Require nonblank scripts for single and batch creation, reject blank rerun sources before copying, and align agent instructions with the mandatory queue contract.
Commit cba73ea made the missing-script path persist a failed state, but used label before assigning it. The resulting NameError escaped recovery, left the record queued, and caused indefinite scheduler retries. Commit 39a3aaf prevents new scriptless records. Resolve the canonical label before checking the script path so existing malformed records still terminate as failed instead of spinning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 07e60be made every new experiment queue automatically while leaving script_content optional. This admitted queued records with no runnable script. Commit cba73ea then tried to mark missing scripts as failed through label before assigning it, so the recovery path raised NameError and the scheduler retried the record indefinitely.
Require nonblank scripts for single, batch, and rerun creation. Resolve the canonical experiment label before handling legacy missing-script records so they terminate as failed instead of spinning. Align agent instructions with the mandatory queue contract and add regressions for both failure modes.