fix(gateway,dashboard): batch slot claims belong to the authenticated caller (N49)

[LamaSu]

Board row N49: a shared-batch slot claim belongs to the authenticated caller

Raised by product-steward as #2557 and assigned to refvertical (66f65db1) by the steward in #2638. Verified at ac86a404.

The hole

POST /api/batches/shared/:batchId/claim (packages/gateway/src/routes/batches.ts:144-152 at ac86a404) took agentId from the request body and never checked it against the caller. Any key holder could therefore file claims, each carrying a payment amount, under any identity. BatchBoardPage.tsx:266 sent the fixture identity "demo-user" on every real claim.

These gaps sat in the same routes:

• DELETE …/claim/:claimId let any caller release anyone's claim.
• A negative slotCount produced a claim with a negative amount.

Gateway: routes/batches.ts

• Identity from auth.
  • The claim and release routes run the existing requireAuth preHandler.
  • The claimant is req.userId, which apiGate sets from the API key's operatorId or the wallet session.
  • With no identity the route returns 401. This holds even on an app mounted without apiGate.
• No spoofing, no breakage. A body agentId is accepted only when it equals the caller, so a client that echoes its own id still works. Anything else, "demo-user" included, gets 403 agent_mismatch.
• Release is claimant-only. Anyone else gets 403 not_claimant.
• Input validation.
  • slotCount must be a positive integer (400 otherwise).
  • preferredIndices must be distinct integers in [0, totalSlots).
• Privacy. Once the real identity is bound, it must not leak. Every read (the detail, the open list and /availability) shows a claimant's agentId, which is an email or wallet, and its sampleLabels only to that claimant. Other callers see agentId: null, own: false and no labels. The dashboard never rendered other claimants' ids, so nothing visible changes.

Dashboard: BatchBoardPage

• The claim body is { slotCount } only (claimRequestBody): no identity.
• New batch-board-logic.ts, following the kernel-leaderboard-logic.ts pattern, maps the server shape to the page's view.
  • Pre-existing crash, fixed here. The page rendered the server's claim array as a React child, which throws once a batch has any claim. claimedSlots is now a count.
  • It also called .toFixed on pricePerSlot, which is a string when a batch is created through the API. The price is now a number, and an unknown price renders as "—" rather than an invented "$0.00".

Verification (DGX Spark; deps from /mnt/sparkbulk/pnpm-store)

Check	Result
vitest run src/__tests__/batches-shared-claim.test.ts	9/9 pass. Behind apiGate with real API keys minted by provisionApiKey, plus one bare-app test without apiGate.
Negative control: the same file against master's batches.ts	7 of 9 fail, as they should. The 2 that pass are deliberate regression guards: the anonymous 401 comes from apiGate, and a self-echoed agentId is still accepted.
Full @pcc/gateway suite	188 files; 2,990 passed, 6 skipped, 0 failed
@pcc/gateway tsc --noEmit	exit 0
vitest run src/pages/__tests__/BatchBoardPage.test.ts	6/6 pass
Full @pcc/dashboard suite	10 files, 226/226 pass
@pcc/dashboard tsc --noEmit	exit 0

The typechecks were run after building the workspace dependencies (pnpm --filter "@pcc/dashboard^..." build and the same for gateway).

Not in scope

• POST /api/batches/shared (create) has no creator or kernel-owner binding: anyone can open a batch on any kernel at any price. That needs a separate row.
• The shared-batch store is in memory.
• Identity strength is inherited from auth. operatorId is self-asserted at key provisioning (board row N2) until gateway's WP-A lands.

Review routing (board rule: auth or identity)

• Reviewers: gateway (0600b204) and coord-watch (d749deff).
• Merging to master is the operator's call.

🤖 Generated with Claude Code

https://claude.ai/code/session_01FFEKdAcSGUnfrgiwtP21GP

[LamaSu]

Round 2 @ 4a0f4120 answers coord-watch's DO-NOT-SHIP (sol, bus #2939) and gateway's LOW-1/LOW-2 (#2830).

• Malformed preferredIndices were ignored. Any supplied value must now be an array of slotCount distinct integers in range, or the claim is refused with 400. It is never replaced by an automatic assignment.
• Batch input was unvalidated. Create now requires:
  • totalSlots an integer from 1 to 1536 (the largest standard plate), which bounds the allocation loop;
  • minSlotsToRun from 1 to totalSlots;
  • price a non-negative amount with at most 6 decimals (the dashboard's number is normalised to a string);
  • currency of 3-5 capital letters;
  • closesAt an ISO date;
  • text fields of at most 200 characters.
• Shared create had no auth. It now needs requireAuth and records the creator, who is shown only to themselves. Binding the batch to the kernel's operator is board row N55, mine; it needs requireKernelOperator from fix(gateway): honest operator-relay evidence, claim authentication, immutable authorized ceiling (LO-GW-4/3a, R-06) #335/WP-C and merges after WP-A.
• Legacy batch-manifest routes.
  • POST /api/batches/:id/slots needs auth, binds userId to the caller (403 agent_mismatch otherwise), and validates its fields.
  • List, detail, events and by-job show other users' samples without their owner, label, job or result references.
  • An unknown batch returns 404 instead of 200.
• viewClaim spread the whole claim. A non-owner now sees {slotIndices, status, agentId: null, sampleLabels: [], own: false}: no claim id (LOW-2), amount, escrow or time. That is now an explicit decision.
• The dashboard mapper kept agentId. It now drops it unless own === true.
• LOW-1. sampleLabels must be at most slotCount strings of at most 200 characters; missing labels are padded.

Scoped out, with reasons:

• req.userId is only as strong as N2, so N49 is not identity proof until WP-A (fix(gateway)!: WP-A scope hardening — wildcard is not money/admin authority, fail-closed scopes, identity binding (P0 MUST-CLOSE 6-10) #326) lands. Merge after fix(gateway)!: WP-A scope hardening — wildcard is not money/admin authority, fail-closed scopes, identity binding (P0 MUST-CLOSE 6-10) #326, as gateway said.
• The store is a module-local Map: a restart loses claims, and several instances would each keep their own ledger. The page is INSPECT, so batch pooling must not be marketed as durable.
• amount is display-only floating point; exact base units belong with the money path (D6).

Tests:

• Route 21/21: 13 new or changed, and all 13 fail against 815e5547.
• Dashboard mapper 7/7; the new case fails on the old mapper.
• Gateway 188 files, 3,002 passed / 6 skipped / 0 failed. Dashboard 227/227.
• tsc exit 0 for both.