chore: continue post-upstream iteration in fork#3
Merged
Conversation
…and on-behalf review standards (#2) * feat: add system-aware parallel pytest tiers * fix: honor cgroup v1 cpu quota for parallel worker sizing * docs: add on-behalf AI review disclosure standard * fix: support cpuacct,cpu cgroup v1 quota mount layout * test: make --parallel activate xdist workers * test: harden bash path assertions on Windows * test: handle zero available memory in parallel sizing * test: make symlink skip capability-based on Windows * test: replace platform skips with capability checks * test: address open review findings for path and xdist checks * test: restore strict setup task assertions * test: honor explicit -n auto and clean InvalidMetadata fallback * test: floor cgroup quota workers and remove dead helper * test: mock os.access for relative installer path case * test: tighten path checks and report effective workers * test: skip parallel xdist hooks when plugin is disabled * test: simplify bash path normalization helper * test: harden parallel args and cwd-safe upgrade tests
…and on-behalf review standards (#2) * feat: add system-aware parallel pytest tiers * fix: honor cgroup v1 cpu quota for parallel worker sizing * docs: add on-behalf AI review disclosure standard * fix: support cpuacct,cpu cgroup v1 quota mount layout * test: make --parallel activate xdist workers * test: harden bash path assertions on Windows * test: handle zero available memory in parallel sizing * test: make symlink skip capability-based on Windows * test: replace platform skips with capability checks * test: address open review findings for path and xdist checks * test: restore strict setup task assertions * test: honor explicit -n auto and clean InvalidMetadata fallback * test: floor cgroup quota workers and remove dead helper * test: mock os.access for relative installer path case * test: tighten path checks and report effective workers * test: skip parallel xdist hooks when plugin is disabled * test: simplify bash path normalization helper * test: harden parallel args and cwd-safe upgrade tests
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
Author
|
Posted on behalf of @LahkLeKey by GitHub Copilot (model: GPT-5.3-Codex). Review round update for commit Addressed latest actionable comments:
Validation run:
Inline replies have been posted on all current open review threads as |
Owner
Author
|
Posted on behalf of @LahkLeKey by GitHub Copilot (model: GPT-5.3-Codex). Review round update for commit Addressed latest actionable comment:
Validation run:
Inline replies have been posted on the current open review thread as |
Comment on lines
+69
to
+72
| def test_path_from_bash_output_tmp_mapping_ignores_existence(monkeypatch): | ||
| monkeypatch.setenv("SPECKIT_BASH_TMPDIR", "/virtual-tmp") | ||
| parsed = path_from_bash_output("/tmp/a/b") | ||
| assert str(parsed).endswith(os.path.join("virtual-tmp", "a", "b")) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Posted on behalf of @LahkLeKey by GitHub Copilot (model: GPT-5.3-Codex).
Continuation PR
This PR starts continuation work in the fork after closing upstream PR github#2877.