feat: add new event types and messages for fee collection and configuration updates#733
feat: add new event types and messages for fee collection and configuration updates#733fadesany wants to merge 2 commits into
Conversation
ogazboiz
left a comment
There was a problem hiding this comment.
good direction adding handlers for the new event types. couple of cleanups before merge:
-
ActivityHistory.tsx:84— themetadataconst in theFEE_COLLECTEDcase is parsed but never read. drop it (the case only usesamountandevent.streamId), or use the parsed metadata to show the fee amount frommetadata.fee_amountif that's what the indexer emits. -
ActivityHistory.tsx:106—ADMIN_TRANSFERREDreads as "Admin transferred" with no context. if the indexer puts the new admin inmetadata, surface it:Admin transferred to {metadata.new_admin}. otherwise add a TODO comment so the next person knows the data is missing. -
rebase on main once you're back. #732 merged and turned on
noUnusedLocalsin the frontend tsconfig, so the unused metadata const above will start failing typecheck once you pull.
git fetch upstream
git rebase upstream/main
git push --force-with-leaseif you want to keep contributing, join us on Telegram: https://t.me/+DOylgFv1jyJlNzM0
230e989 to
c0c574a
Compare
|
thanks, both items addressed cleanly. CI hasn't triggered on the new commit yet — push an empty commit ( if you want to keep contributing, join us on Telegram: https://t.me/+DOylgFv1jyJlNzM0 |
|
actually disregard that — i approved the pending workflow runs (CI needed maintainer approval since you're a first-time contributor). they're running now. once green i'll merge. |
|
all ci passed |
closes #657