Skip to content

feat: add new event types and messages for fee collection and configuration updates#733

Open
fadesany wants to merge 2 commits into
LabsCrypt:mainfrom
fadesany:ActivityHistory-renderEventMessage
Open

feat: add new event types and messages for fee collection and configuration updates#733
fadesany wants to merge 2 commits into
LabsCrypt:mainfrom
fadesany:ActivityHistory-renderEventMessage

Conversation

@fadesany
Copy link
Copy Markdown

@fadesany fadesany commented Jun 2, 2026

closes #657

Copy link
Copy Markdown
Contributor

@ogazboiz ogazboiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good direction adding handlers for the new event types. couple of cleanups before merge:

  1. ActivityHistory.tsx:84 — the metadata const in the FEE_COLLECTED case is parsed but never read. drop it (the case only uses amount and event.streamId), or use the parsed metadata to show the fee amount from metadata.fee_amount if that's what the indexer emits.

  2. ActivityHistory.tsx:106ADMIN_TRANSFERRED reads as "Admin transferred" with no context. if the indexer puts the new admin in metadata, surface it: Admin transferred to {metadata.new_admin}. otherwise add a TODO comment so the next person knows the data is missing.

  3. rebase on main once you're back. #732 merged and turned on noUnusedLocals in the frontend tsconfig, so the unused metadata const above will start failing typecheck once you pull.

git fetch upstream
git rebase upstream/main
git push --force-with-lease

if you want to keep contributing, join us on Telegram: https://t.me/+DOylgFv1jyJlNzM0

@fadesany fadesany force-pushed the ActivityHistory-renderEventMessage branch from 230e989 to c0c574a Compare June 3, 2026 12:45
@fadesany fadesany requested a review from ogazboiz June 3, 2026 12:45
@ogazboiz
Copy link
Copy Markdown
Contributor

ogazboiz commented Jun 3, 2026

thanks, both items addressed cleanly. CI hasn't triggered on the new commit yet — push an empty commit (git commit --allow-empty -m 'trigger ci') or close/reopen the PR to retrigger, then ping back when green and i'll merge.

if you want to keep contributing, join us on Telegram: https://t.me/+DOylgFv1jyJlNzM0

@ogazboiz
Copy link
Copy Markdown
Contributor

ogazboiz commented Jun 3, 2026

actually disregard that — i approved the pending workflow runs (CI needed maintainer approval since you're a first-time contributor). they're running now. once green i'll merge.

@fadesany
Copy link
Copy Markdown
Author

fadesany commented Jun 3, 2026

all ci passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Frontend] ActivityHistory renderEventMessage doesn't cover FEE_COLLECTED / FEE_CONFIG_UPDATED / ADMIN_TRANSFERRED

2 participants