generate test tls key at runtime instead of embedding#88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the secret-scanning alert for
crates/mqtt5/src/transport/tls.rs(RSA Private Key, commitdea578ac).The TLS PEM-loading unit test embedded a hardcoded RSA private key blob, which secret scanning flags. It was a throwaway test fixture guarding nothing, but its presence in source keeps triggering detection.
Change
rcgen::KeyPair::generate().serialize_pem()instead of embedding a private-key literal.rcgenas a dev-dependency.load_client_key_pem_bytesuses rustlspem_slice_iter, which accepts the PKCS#8 PEM that rcgen emits. Test passes; clippy clean.Not addressed here (no code in current tree)
The other two alerts are history-only test fixtures already removed from tracking in
65eb0c5and gitignored (test_certs/*.key):test_certs/ca.key(commite340249)test_certs/client.key(commite340249)Per decision, git history will not be rewritten — those alerts should be dismissed as "used in tests". After this merges, the
tls.rsalert can likewise be dismissed (the key still exists in history, only removed from HEAD).