wazp_cosmodc2 (unfinished, updated to CLPipe naming) - #33
Draft
eduardojsbarroso wants to merge 5 commits into
Draft
wazp_cosmodc2 (unfinished, updated to CLPipe naming)#33eduardojsbarroso wants to merge 5 commits into
eduardojsbarroso wants to merge 5 commits into
Conversation
…t tags - clpipeline package/module/imports -> clpipe (dir, files, CLI entrypoint, conda env names, CI, docs, examples, notebooks, tutorials) - FirecrownPipeline -> CLPFirecrown, TJPCovPipeline -> CLPCovariance (class names, stage `name`, config yml top-level keys, module_name paths) - FirecrownPipeline outputs renamed at the ceci tag level: cluster_counts_mean_mass_redshift_richness -> sampler_file, cluster_redshift_richness -> likelihood_file, cluster_richness_values -> priors_file. On-disk output filenames are unchanged: added `aliases:` blocks to every example pipeline yml declaring the CLPFirecrown stage so ceci's default tag->filename naming still resolves to the old basenames.
Homepage/Issues still referenced eduardojsbarroso/CLPipe from before the repo lived under the LSSTDESC org; the CLPipeline->CLPipe rename carried that stale owner forward verbatim.
Aliases would have kept output filenames pinned to the old cluster_counts_mean_mass_redshift_richness/cluster_redshift_richness/ cluster_richness_values basenames forever. Instead, let ceci's default tag->filename naming apply, so outputs are written as sampler_file.ini, likelihood_file.py, and priors_file.ini: - Removed the aliases: block from all 36 example pipeline ymls. - clp_firecrown.py's generated sampler ini now cross-references its sibling likelihood/values files by their actual (computed) basenames instead of hardcoding the old ones. - Renamed the 10 checked-in example output artifacts and fixed the values=/likelihood_source= lines inside each generated sampler_file.ini. - Updated every launch_*.sh that invoked `cosmosis cluster_counts_mean_mass_redshift_richness.ini` to `cosmosis sampler_file.ini`. - Updated tests/test_clp_firecrown.py to match.
…line The assertion compared the SSC-replaced variance against the mock fixture's hardcoded data value (40.0), not against the theory model's own prediction for that bin. But replace_crow_counts only guarantees full_cov[i, i] >= theory_counts[i] (Poisson term + non-negative SSC addition) -- there's no guarantee theory_counts[i] itself equals the arbitrary mock value, and #28's fiducial-cosmology change (using fiducial_cosmology.to_ccl(), which doesn't set transfer_function) shifted that prediction to ~39.67, just under 40, breaking the test. Exposes the actual theory prediction as stage.crow_theory_counts (set right before replace_crow_counts returns) so the test can assert against the real invariant instead of an incidental match to the fixture's round number.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renamed everything to CLPipe here too, kept it as a draft since I never finished running things on this branch.