Repository navigation
Harden agent CORS and restore deterministic core validation - #3
Open
nicholas-ruest wants to merge 6 commits into
Open
nicholas-ruest wants to merge 6 commits into
nicholas-ruest wants to merge 6 commits into
Conversation
Require an explicit origin allowlist at the public Cloud Function boundary, add focused regression tests and deterministic agents CI, and prevent ordinary main pushes from publishing packages or production documentation. Validated with the deploy graph build, focused boundary tests, MetaHarness, bounded Darwin evaluation, and a signed Flywheel replay.
Run the actual packages/core commands from their package directory, add a deterministic lockfile, pin Actions, retire EOL Node 16, and bound every job. Preserve browser, bundle, audit, unit, integration, macOS, Windows, and Linux coverage.
Pin Playwright 1.40.1 so the package's Node 18 contract remains installable, regenerate the exact lockfile, and remove the nonexistent TypeScript `web` type library already covered by the DOM lib.
Declare the actual Node 20 floor, pin Playwright 1.64.0, add tslib, remove strict TypeScript and ESLint blockers, and keep the hosted matrix on supported Node 20/22 releases.
Pass explicit test paths to Vitest instead of combining --dir with the repository include pattern, which produced a false zero-test failure.
Use monotonic high-resolution timing for batch scans, preserve absolute error indices across concurrency chunks, and add a scoped Playwright smoke test for the built browser bundle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This existing recovery PR now combines the original Cloud Function hardening with a reproducible Node-core validation repair.
CORS_ALLOWED_ORIGINScontains an exact originExact candidate
60bcd3c463228ee8c8ccadc4c7c560502d73e2731c46282495b94bb1fcae2d9e63cf34f495226699Measured evidence
Local package validation:
npm run lint: passnpm run typecheck: passnpm audit --omit=dev --audit-level=moderate: 0 findingsHosted exact-head evidence:
MetaHarness / Darwin / Flywheel
Pinned upstream MetaHarness revision:
e0dfd44da72b7adfb7c57fdd42d124be58ed7086.0.4.17: score 64, compile confidence 90, task coverage 92, safety 95, hard constraints 6/60.10.3: real sandbox, seed101308, one generation/child; baseline and child both 0.985; baseline retained, delta 0.0000.1.12: frozen contract improved 0/22 to 22/22, anchor 1.0, candidate promotedc5942e7c9bf8f28fe7af47a6ec3887d11eeb3f8c8e8601cc6a7a54969ea0b981gen1(contract) → gen0(root)Merge blockers
The repository-wide Rust workflow is independently red:
https://github.com/LLM-Dev-Ops/infra, resolved revisiona8bc89c190f63b139812f30a54e21a25b8f70e81cargo fmt --checkreports widespread pre-existing workspace formatting driftcargo auditreports 17 vulnerabilities and 12 allowed warnings across the 714-crate lockfile, including affectedazure_core,h2,idna,pyo3,quick-xml,quinn-proto,rustls, andrustls-webpkipathsNo advisory was ignored, no required check was weakened, and no branch protection was bypassed. This PR must remain unmerged until the exact candidate has a fully green required workflow.
Rollback
Before merge, close this PR. After a merge, revert its merge commit (preferred). If individual branch commits must be unwound, revert the commits from
60bcd3c463228ee8c8ccadc4c7c560502d73e273back through5f1c340233c4b0d36b8d85bd3b063b7e101b9987in reverse chronological order. For browser access, configure exact HTTPS origins rather than restoring wildcard CORS.