Skip to content

Restore the Node workspace quality gate - #2

Open
nicholas-ruest wants to merge 4 commits into
mainfrom
metaharness/incident-manager-2026-10-10
Open

nicholas-ruest wants to merge 4 commits into
mainfrom
metaharness/incident-manager-2026-10-10

Conversation

@nicholas-ruest

@nicholas-ruest nicholas-ruest commented Oct 10, 2026 •

Copy link
Copy Markdown
Member

Why

The configured Node/TypeScript workspace did not build, and an unused root claude-flow runtime dependency pulled 38 production audit findings into this repository.

Change

  • remove the unused claude-flow production dependency and regenerate the lockfile
  • export the existing no-op telemetry factory and restore the escalation agent's workspace contract
  • remove compile-blocking dead code and add two executable contract tests
  • make empty test discovery portable across the declared Node 20 floor
  • add pinned, Linux-first Node 20 CI for clean install, workspace build/tests, and production audit
  • commit the frozen MetaHarness/Darwin/Flywheel evidence and rollback record

Measured evidence

Baseline bcb8c8d027997c3363a9fd0ebd0ddc9c086227c6:

  • clean install: pass
  • configured workspace build: fail with 6 TypeScript errors
  • production audit: 38 (2 critical, 26 high, 10 moderate)
  • production dependency count: 435
  • functions empty-test command: passes on Node 24 but fails on declared Node 20

Exact candidate 834452bad11f38fd70cf73bb9991f83d9d19c299:

  • npm ci --ignore-scripts: pass
  • configured workspace build: pass
  • configured workspace tests: 106 pass
  • production audit: 0
  • production dependency count: 12
  • escalation CLI help smoke test: pass
  • Node workspace quality run #2: success on Ubuntu 24.04 / Node 20.19.5

Flywheel 0.1.12 promoted the final candidate from 2/6 to 6/6 with the architecture anchor unchanged at 2/2. Ed25519 replay passed. Darwin 0.10.3 found no better harness mutation and retained the baseline harness.

Independent merge blocker

Build feature matrix run #8 remains red. All three Rust builds fail before compilation because the pinned sentinel tag resolves a transitive private LLM-Dev-Ops/infra branch that Actions cannot authenticate; the upstream pin guard passes. The isolated Rust 1.84.1 check reproduces the same HTTP 401. This PR does not alter Rust or persistence code, but the failure remains unresolved and is not treated as passing.

Rollback

Revert the two PR commits. No schema, state, or persistence migration is involved.

Remove an unused claude-flow runtime dependency, restore the real TypeScript workspace contract, and add deterministic Linux CI plus reproducible MetaHarness evidence.
Use Node's native test discovery so a workspace with no tests exits cleanly on the declared Node 20 floor and automatically discovers tests when added.
Preserve retry semantics and append-only service writes; add frozen native HTTP regression gates and real Flywheel CI evaluation.

Signed-off-by: Codex <codex@users.noreply.github.com>
Reject the initial refactor's NaN retry regression, reproduced with a real HTTP child-process watchdog. Keep the frozen transport evaluator unchanged and add a supplemental regression test.

Signed-off-by: Codex <codex@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant