Fix/ap phot diagnostic images - #132
Merged
Merged
Conversation
added 2 commits
July 27, 2026 23:36
…perture/annulus when drawing around the target star
capetillo
reviewed
Jul 29, 2026
| radius_full = max(arcsec_to_pixels(frame.header, aperture_radius), 14.0) | ||
| x0, y0, x1, y1 = _crop_bounds(positions, pad=2.0 * radius_full, width=width, height=height) | ||
| # The target's circles are the operation's real apertures in this frame's pixels; the | ||
| # candidates' shared circle keeps a floor so it stays visible on wide-pixel-scale frames. |
Contributor
There was a problem hiding this comment.
Why are these vars named something_something_full? What's the full?
Contributor
Author
There was a problem hiding this comment.
Good question... Maybe _pixel would be a better descriptive name. I think its trying to say they are those values in pixel coordinates on the "full" size image, vs. the scaled down image we draw later on.
capetillo
approved these changes
Jul 29, 2026
capetillo
left a comment
capetillo
left a comment
Contributor
There was a problem hiding this comment.
looks good just have a question about "full"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sizes the circle drawn around the target to the
aperture_radiusand also draws the inner/outerannuluswith a half width line.Tweaks the color and size of the images for contrast and showing it full screen.