Feature/hr diagram - #264
Open
jnation3406 wants to merge 3 commits into
Open
Conversation
capetillo
reviewed
Jul 27, 2026
|
|
||
| // Abramowitz & Stegun 7.1.26 error function (max error ~1.5e-7), for the split-normal CDF | ||
| function erf(x) { | ||
| const t = 1 / (1 + 0.3275911 * Math.abs(x)) |
Collaborator
There was a problem hiding this comment.
can we declare these values as a const?
capetillo
reviewed
Jul 27, 2026
| // Abramowitz & Stegun 7.1.26 error function (max error ~1.5e-7), for the split-normal CDF | ||
| function erf(x) { | ||
| const t = 1 / (1 + 0.3275911 * Math.abs(x)) | ||
| const y = 1 - (((((1.061405429 * t - 1.453152027) * t) + 1.421413741) * t - 0.284496736) * t + 0.254829592) * t * Math.exp(-x * x) |
capetillo
reviewed
Jul 27, 2026
| return area.left + fraction * (area.right - area.left) | ||
| } | ||
|
|
||
| function pixelToValue(chart, pixel) { |
Collaborator
There was a problem hiding this comment.
Do you think this function could be used elsewhere? If so, it should be turned into a util function
capetillo
reviewed
Jul 27, 2026
| const bounds = axisBounds() | ||
|
|
||
| const datasets = [buildStarDataset()] | ||
| if (props.isochrone && props.isochrone.length && props.isochroneVisible) { |
Collaborator
There was a problem hiding this comment.
is this just an if statement? I think it should be contained
capetillo
reviewed
Jul 27, 2026
| type: Array, | ||
| required: true | ||
| }, | ||
| fehNodes: { |
capetillo
approved these changes
Jul 30, 2026
capetillo
left a comment
capetillo
left a comment
Collaborator
There was a problem hiding this comment.
small comments regarding magic numbers. I think it looks good as a skeleton. There are a couple of parts here and there that are Claude-esque by having all the falllbacks. But it looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first draft of the HR diagram views. The structure of it should at least provide a strong starting point for implementing it if we don't want to use exactly what is here.
Improvements to be made: