Skip to content

Rename the pin check to "Action pin check" - #17

Merged
GavinLucas merged 1 commit into
mainfrom
rename-action-pin-check
Oct 15, 2026
Merged

GavinLucas merged 1 commit into
mainfrom
rename-action-pin-check

Conversation

@claudeleet

Copy link
Copy Markdown
Contributor

What this changes

  1. premerge.yaml: the job is now "Action pin check".
  2. README.md: the example caller job uses the new name.
  3. actions/action-pins/action.yml: the action's name: is "Action pin check".

"Action pins are immutable" stopped being accurate when the check began accepting this repository's major-version tag, which moves by design.

Rulesets

This repository's main ruleset requires no status checks by name, so no ruleset change is needed here. Each calling repository renames its own job in its own pull request, and its ruleset's required check changes from "Action pins are immutable" to "Action pin check" when that pull request merges.

Tested

  • 82 tests pass locally; actionlint is clean.
  • No reference to the old name remains (git grep).

No release is needed for this: the action's name is metadata, and callers name their own jobs.

"Action pins are immutable" stopped being true when the check began accepting this repository's
major-version tag, which moves by design.  The new name says what the job is without claiming
every reference is immutable.  The README example and the action's own name follow, so callers
copying the example use the new job name.  This repository's ruleset requires no status checks
by name, so nothing else changes here; each caller's ruleset changes with that caller's rename.
@github-actions

Copy link
Copy Markdown

Claude review: approve

Findings

None. Nothing here should block a merge.

The pull request renames the action-pins check from "Action pins are immutable" to "Action pin check" in three places:

  • the job name: in .github/workflows/premerge.yaml:22
  • the caller example in README.md:29
  • the composite action's name: in actions/action-pins/action.yml:1

The old name was no longer accurate, because the check now also accepts this repository's movable major-version tags (README.md:256-261, actions/action-pins/action.yml:4-15). The new name makes no claim about immutability, so it stays true.

What I checked

  • Leftover references to the old name. I searched every file in the repository for "pins are immutable": there are no matches. Nothing in tests/ refers to job or action display names.
  • Effect on callers. A composite action's name: is only metadata. It does not appear in a caller's check-run or step names, so callers on @v2 see no change when this is released. Callers set their own job names, and the README example is only an example. Under the rule at README.md:273-277, this is not a breaking change and does not need a new major version.
  • This repository's required checks. The commit message says this repository's ruleset requires no status checks by name. That matches the README, which describes the ruleset only as a v* tag protection. Nothing in the repository refers to the job name in any other way.
  • Recorded state in added lines. The three changed lines are names only, so there are no counts, dates or claims about configuration held elsewhere. The statement about the ruleset is in the commit message, which is the right place for it.
  • Repository instructions. There is no CLAUDE.md or AGENTS.md, so I reviewed against the README's "Versions and releases" and "Changing anything here" sections.

Not checked

  • The rulesets on GitHub, either for this repository or for callers. A caller that copied the old job name and requires it as a status check will need to update its ruleset when it renames its own job. The commit message already says so, and nothing in this repository forces that rename.
  • I did not run actionlint or the tests. The change touches no logic, step or test.

full review of 23a9b04aa39e..20b2c0639c7c. Run.

@GavinLucas
GavinLucas merged commit 397a1c8 into main Oct 15, 2026
9 checks passed
@GavinLucas
GavinLucas deleted the rename-action-pin-check branch October 15, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants