Move To Roslyn #35 WIP by codeFather2 · Pull Request #45 · KvanTTT/CSharp-Minifier

codeFather2 · 2018-02-19T17:54:22Z

No description provided.

KvanTTT

Let's completely remove the dependency on NRefactory.
Let's introduce continuous integration system (CI) appveyor.com.
- Taka look on config from PT.PM project.

KvanTTT · 2018-02-20T19:53:20Z

+
+        private List<string> _existingNames = new List<string>();
+
+        private const int FirstSymbolCode = 97;


Use getting code from string literals. I mean int FirstSymbolCode = (int)'a';

Is it possible to use char instead of int everywhere?

KvanTTT · 2018-02-20T19:54:54Z

+            _options = options ?? new MinifierOptions();
+            _identifierGenerator = new IdentifierGenerator();
+            //Add cause MSBuild does not work without it
+            var _ = typeof(Microsoft.CodeAnalysis.CSharp.Formatting.CSharpFormattingOptions);


Can you add a link where such behaviour explained?

this decision is possible to avoid the exception of the type "The language 'C#' is not supported". Reason in the latest version of MSBuild, which does not load the required library, since it believes that it is not used in this program, although in fact it is applied.

I mean add a website link with description to comment in the code.

KvanTTT · 2018-02-20T19:55:54Z

+            var document = _workspace.AddDocument(project.Id, "Doc", source);
+            _semanticModel = document.GetSemanticModelAsync().Result;
+            var newNode = _semanticModel.SyntaxTree.GetRoot();
+            foreach (KeyValuePair<VariableDeclaratorSyntax, string> variable in _identifierGenerator.RenamedVariables)


Use more line breaks. At least insert line breaks before statements (if, foreach, while etc.).

KvanTTT · 2018-02-20T19:57:57Z

+            }
+
+            return newNode;
+        }


Move initialization stage to the separated method. Maybe Init.

KvanTTT · 2018-02-20T19:59:42Z

+
+namespace CSharpMinifier.Rewriters
+{
+    class CSharpRewriter : CSharpSyntaxRewriter


Specify the more specialized name for this class. This is not just a rewriter, but an identifier magnifier.

So, the better name is TokensMinifier or NamesMinifier.

KvanTTT · 2018-02-20T20:08:29Z

+            Options = options ?? new MinifierOptions();
+            IgnoredIdentifiers = ignoredIdentifiers?.ToList() ?? new List<string>();
+            IgnoredComments = ignoredComments?.ToList() ?? new List<string>();
+        }


In this case, the method should take not only arrays but enumerables too.

After that use the following code:

IgnoredIdentifiers = ignoredIdentifiers as List<string> ?? ignoredIdentifiers?.ToList() ?? new List<string>();

KvanTTT · 2018-02-20T20:10:33Z

+{
+    public class RoslynMinifier : IMinifier
+    {
+        public SyntaxTree SyntaxTree { get; private set; }


It makes sense to remove this property and pass SyntaxTree to the method via arguments instead. Advantage: getting rid of yet another side effect.

KvanTTT · 2018-02-20T20:15:06Z

+                    continue;
+                return fragment + lastChar;
+            }
+            return IncrementName(fragment) + Char.ConvertFromUtf32(FirstSymbolCode);


Try to rewrite this method in a more clear way:

Get rid of recursion.

Remove Char.ConvertFromUtf32. It's possible to use ToString method here.

KvanTTT · 2018-02-20T20:18:36Z

+
+        public override SyntaxNode VisitFieldDeclaration(FieldDeclarationSyntax node)
+        {
+            if(_options.LocalVarsCompressing && node.Modifiers.Any(m => m.Value.Equals("private")))


Missed space after if.

KvanTTT · 2018-02-20T20:20:10Z

+            var _ = typeof(Microsoft.CodeAnalysis.CSharp.Formatting.CSharpFormattingOptions);
+        }
+
+        public SyntaxNode VisitAndRename(SyntaxNode node)


I think the Visitor functionality doesn't matter in this case. Rename method to MinifyNames or MinifyNamesRecursive.

# Conflicts: # CSharpMinifier/IdentifierGenerator.cs # CSharpMinifier/Rewriters/TokensMinifier.cs

KvanTTT · 2018-02-24T10:23:36Z

+<<<<<<< HEAD:CSharpMinifier/Rewriters/TokensMinifier.cs
+
+=======
+>>>>>>> 5abeb53995ac7760de4ef050808dc751ceb38a2d:CSharpMinifier/Rewriters/CSharpRewriter.cs


What is it? Please resolve merge conflicts and fix build.

KvanTTT · 2018-02-24T10:24:49Z

+            _options = options ?? new MinifierOptions();
+            _identifierGenerator = new IdentifierGenerator();
+            //Add cause MSBuild does not work without it
+            var _ = typeof(Microsoft.CodeAnalysis.CSharp.Formatting.CSharpFormattingOptions);


I mean add a website link with description to comment in the code.

KvanTTT · 2018-02-24T10:25:08Z

        {
-            node = Visit(node);
-            return RenameAll(node);
+            foreach(var project in _workspace.CurrentSolution.Projects)


Please use whitespace before the parenthesis.

KvanTTT · 2018-02-24T10:27:45Z

                (newNode, document) = Rename(nodeToSearch, document, variable.Value);
            }
+
+            foreach(var method in _identifierGenerator.RenamedMethods)


Type name for a not obvious code.

KvanTTT · 2019-02-14T12:53:50Z

Hi! What status of this request? 😄 How much work to fix?

codeFather2 and others added 5 commits February 13, 2018 17:15

WIP: AddRoslyn

8aa51b9

WIP: Roslyn adaptation

898f3f9

WIP: Add LocalCompress roslyn

9ed00c8

WIP version

862d133

WIP: Move To Roslyn

569e406

codeFather2 changed the title ~~Mpve To Roslyn #35 WIP~~ Move To Roslyn #35 WIP Feb 19, 2018

Add Properties

5abeb53

KvanTTT reviewed Feb 20, 2018

View reviewed changes

codeFather2 added 3 commits February 23, 2018 16:47

Add Minifying from files ref KvanTTT#35

d2f9a5c

Fix code style

243194d

Merge branch 'master' of https://github.com/codeFather2/CSharp-Minifier

b44d228

# Conflicts: # CSharpMinifier/IdentifierGenerator.cs # CSharpMinifier/Rewriters/TokensMinifier.cs

KvanTTT reviewed Feb 24, 2018

View reviewed changes

codeFather2 and others added 4 commits February 24, 2018 13:36

Fix Merge conflicts

b6c5fd0

Remove old references to NRefactory

b5b9f34

Fixed missed packages errors: added packages to CSharpMinifier.Tests.

ae03a91

WIP (Fix renaming)

d128dd6

This was referenced Feb 20, 2019

Roslyn version for .NET Standard 🚧 codeFather2/CSharp-Minifier#1

Open

Roslyn version for .NET Standard 🚧 #46

Open


		private List<string> _existingNames = new List<string>();

		private const int FirstSymbolCode = 97;

Conversation

codeFather2 commented Feb 19, 2018

Uh oh!

KvanTTT left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codeFather2 Feb 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

KvanTTT commented Feb 14, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

KvanTTT left a comment •

edited

Loading

codeFather2 Feb 21, 2018 •

edited

Loading