Skip to content

Import Niu installations as independent terminal profiles - #1020

Merged
Kuddev merged 3 commits into
mainfrom
review/niu-directory-950-20261117
Nov 17, 2026
Merged

Kuddev merged 3 commits into
mainfrom
review/niu-directory-950-20261117

Conversation

@Kuddev

@Kuddev Kuddev commented Nov 17, 2026 •

Copy link
Copy Markdown
Owner

Importing the directory containing niu.exe now offers Niu in the default shell picker. Its saved profile launches the selected executable with --login -i, using the generic shell path. The test covers installs at the selected root, bin, and usr/bin and checks the persisted profile ID and arguments.

Current source 303a7f4e is stacked on #1019 (53b8f42b). The stack includes the foreground fixture repair with unchanged production code; its native ARM regression passed seven cases three times and detected loss of foreground ownership.

Windows x64 installed-shell acceptance passed on 303a7f4e. Using the SHA-256-verified upstream 1.5.0 installer, the test passed the real install directory to the production importer and confirmed the default selection through the production handler in a GPUI test window. The application’s own close command exited normally, the new process started the installed niu.exe in its first pane, and a new tab started a distinct niu.exe. Both real sessions evaluated an arithmetic marker. Windows file identity was checked for each pane’s root process, and the saved profile contained --login -i. The native operating-system folder chooser itself was not automated.

Five-platform PR tests are still pending.

poorjackman and others added 2 commits November 11, 2026 22:56
Register niu.exe in scan_directory under its own shell family id `niu`
(display name "Niu", launch args `--login -i`, verified interactively on
Windows). Keeping it separate from `bash` means imported Niu profiles take
the generic profile launch path instead of Pebrel's Bash PTY integration.
Add a `niu` display-name fallback in display_name_for_id and a regression
test covering the directory/bin/usr-bin layouts, save/reload roundtrip,
and the `profile:niu|<id>` settings id. CHANGELOG notes the addition.
@github-actions github-actions Bot added the size/S ≤100 行源码改动 label Nov 17, 2026
@Kuddev
Kuddev changed the base branch from review/graphics-controls-819-20261117 to main November 17, 2026 12:38
@Kuddev
Kuddev marked this pull request as ready for review November 17, 2026 12:38
@Kuddev
Kuddev merged commit 303a7f4 into main Nov 17, 2026
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S ≤100 行源码改动

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants