Repository navigation
Import Niu installations as independent terminal profiles - #1020
Merged
Merged
Conversation
Register niu.exe in scan_directory under its own shell family id `niu` (display name "Niu", launch args `--login -i`, verified interactively on Windows). Keeping it separate from `bash` means imported Niu profiles take the generic profile launch path instead of Pebrel's Bash PTY integration. Add a `niu` display-name fallback in display_name_for_id and a regression test covering the directory/bin/usr-bin layouts, save/reload roundtrip, and the `profile:niu|<id>` settings id. CHANGELOG notes the addition.
Kuddev
changed the base branch from
review/graphics-controls-819-20261117
to
main
November 17, 2026 12:38
Kuddev
marked this pull request as ready for review
November 17, 2026 12:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Importing the directory containing
niu.exenow offers Niu in the default shell picker. Its saved profile launches the selected executable with--login -i, using the generic shell path. The test covers installs at the selected root,bin, andusr/binand checks the persisted profile ID and arguments.Current source
303a7f4eis stacked on #1019 (53b8f42b). The stack includes the foreground fixture repair with unchanged production code; its native ARM regression passed seven cases three times and detected loss of foreground ownership.Windows x64 installed-shell acceptance passed on
303a7f4e. Using the SHA-256-verified upstream 1.5.0 installer, the test passed the real install directory to the production importer and confirmed the default selection through the production handler in a GPUI test window. The application’s own close command exited normally, the new process started the installedniu.exein its first pane, and a new tab started a distinctniu.exe. Both real sessions evaluated an arithmetic marker. Windows file identity was checked for each pane’s root process, and the saved profile contained--login -i. The native operating-system folder chooser itself was not automated.Five-platform PR tests are still pending.