Repository navigation
Decode bounded PNG transfers from terminal readers - #1018
Merged
Merged
Conversation
Co-authored-by: glitch-cmyk658 <278580960+glitch-cmyk658@users.noreply.github.com>
Kuddev
changed the base branch from
main
to
fix/foreground-setup-timing-20261117
November 17, 2026 08:43
Kuddev
changed the base branch from
fix/foreground-setup-timing-20261117
to
main
November 17, 2026 12:36
Kuddev
marked this pull request as ready for review
November 17, 2026 12:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A valid 4096×2160 PNG from a terminal reader can exceed the frontend’s 32 MiB owned queue even though the wire transfer fits its 64 MiB staging budget. This first part of #819 sends PNG and raw transfers through the existing weak-reference queue and background decoder. Core admission accounts for decoded pixel cost and source sample depth. Ordinary inline images retain their previous limits. Raw, chunked and unpadded transfers, replacement headers, ordinary queries, and 8/16-bit PNG decoding have regression coverage.
Current source
ba265c10is stacked on #1021 (ec960e69). The stack includes the foreground fixture repair with unchanged production code; its native ARM regression passed seven cases three times and detected loss of foreground ownership.The previously verified transfer source is
58b1481d; it passed the real PTY/pixel test and 371 core, 12 grid, and 25 decoder tests. Its Windows ARM failure was isolated to the initial foreground fixture: on the same source the test passed three times normally and failed at the identical line with the worker paused (diagnosis). No retry of that obsolete full run is needed.Current-source native PTY and window acceptance passed: 371 core (two ignored), 12 grid and 25 decoder tests. The two visible test colors each occupied 7,832 pixels and disappeared after deletion. Five-platform CI is pending.