OIDC implementation#1701
Conversation
…d login flow This change also includes minor edits to logging to allow for log level to be customized via TOML.
There was a problem hiding this comment.
I've done a rough first review of the changes.
Thanks for taking up the work! The general concepts are fine, it's mostly some nitpicking on style.
CI also failed on the formatting and linting of the frontend and backend files. You should be able to fix them automatically with the relevant package commands.
(e.g. npm run format in the frontend and uv run ruff format src if you have uv installed on the backend) You can also do it manually of course.
I recommend to first read through the full comments, as I made some comments on pieces of code that I would actually just remove all together.
|
Should I attempt to draft translations for the text "Login with OIDC" in all the currently supported languages? I just wanted to know before I write a bunch of simple google translate entries that may only be kind of right. Happy to create them. And really appreciate the work you've done on this project! |
|
I've personally so far not done translations to other languages myself and just stuck to the English one. That said, I don't particularly mind if you do run them to a translator, or only do a specific few, but it's not a requirement. |
I have tried to implement OIDC as minimally invasive as I can before I get too much further I wanted to know if this is inline with your direction for the project. Currently Translations are the only missing item (Login & Login with)