Skip to content

OIDC implementation#1701

Open
nwhansen wants to merge 2 commits intoKruptein:devfrom
nwhansen:oidc-implementation
Open

OIDC implementation#1701
nwhansen wants to merge 2 commits intoKruptein:devfrom
nwhansen:oidc-implementation

Conversation

@nwhansen
Copy link
Copy Markdown
Contributor

I have tried to implement OIDC as minimally invasive as I can before I get too much further I wanted to know if this is inline with your direction for the project. Currently Translations are the only missing item (Login & Login with)

…d login flow

This change also includes minor edits to logging to allow for log level to be customized via TOML.
Copy link
Copy Markdown
Owner

@Kruptein Kruptein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done a rough first review of the changes.

Thanks for taking up the work! The general concepts are fine, it's mostly some nitpicking on style.

CI also failed on the formatting and linting of the frontend and backend files. You should be able to fix them automatically with the relevant package commands.
(e.g. npm run format in the frontend and uv run ruff format src if you have uv installed on the backend) You can also do it manually of course.

I recommend to first read through the full comments, as I made some comments on pieces of code that I would actually just remove all together.

Comment thread server/src/api/http/auth.py
Comment thread server/src/api/http/oidc.py
Comment thread server/src/api/http/oidc.py
Comment thread server/src/api/http/oidc.py
Comment thread server/src/config/__init__.py
Comment thread server/src/api/http/oidc.py
Comment thread server/src/api/http/oidc.py
Comment thread server/src/api/http/oidc.py
Comment thread server/src/api/http/oidc.py
Comment thread server/src/api/http/oidc.py
Comment thread client/src/auth/Login.vue
@nwhansen
Copy link
Copy Markdown
Contributor Author

Should I attempt to draft translations for the text "Login with OIDC" in all the currently supported languages? I just wanted to know before I write a bunch of simple google translate entries that may only be kind of right. Happy to create them. And really appreciate the work you've done on this project!

@Kruptein
Copy link
Copy Markdown
Owner

I've personally so far not done translations to other languages myself and just stuck to the English one.

That said, I don't particularly mind if you do run them to a translator, or only do a specific few, but it's not a requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants