UE4.24.3 - Fixes for successful packaging of plugin#1
Open
stfnrkssn wants to merge 3 commits into
Open
Conversation
BNiceguy0154651651
approved these changes
May 4, 2020
…nd as replicatedmovementmode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes for warnings and critical issuing when packaging plugin.
Warnings:
Critical:
Movement Comp WITH_EDITOR members replaced WITH_EDITORONLY_DATA. Unknown but critical issue.
FORCEINLINE constructors not implemented inline. Removed FORCEINLINE, might just move the implementation to the header instead.
AIModule required for PathfollowingComponent in ExtCharMovementComp
Error logging in Editor Module Casues Packaging to fail. Only Relevant in Editor builds but packaging will still fail in development and shipping when log error is encountered. Wrapped in preprocessor macros for current build type