fix(analytics): preserve selected hash size in links - #1967
Merged
efiten merged 3 commits intoSep 6, 2026
Conversation
Collaborator
|
Merging. CI had never run on this (it was stuck in The change is well contained and the details are right where they usually are not:
Reading the byte size on every render rather than once at init is the part that actually fixes it: a tab switch, filter change or theme refresh re-renders, and the old
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Red commit:
5a5ecb6(local browser: 14 passed, 8 behavior assertion failures before the fix).Hash Issues links now restore
bytes=1|2|3for the selected control and its matrix/collision data. Missing or malformed values default to one byte. Selector clicks, section/top links, tab-bar changes, filters and theme refreshes retain the chosen view through the existing URL helper.Fixes #1914.
test-issue-1306-collisions-terminology-e2e.js:242. The existing CI-selected harness passes 23 checks, including distinct nonempty collision rows for each byte size. Its original assertions remain.http://127.0.0.1:55634with the local fixture API, plus reviewed matrix/risk screenshots. Region refresh passed; area coverage skips because the fixture has no areas.fb482fe.Preflight overrides
run-all.shis absent. Corresponding scope, PII, syntax, whitespace and CSS checks passed; no SQL, migration or image changes require those gates.