Fix/affricates - #19
Open
arunasrivastava wants to merge 7 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes L2Arctic affricate label handling by preserving phoneme-token boundaries when available.
Examples for review:
data/ExamplesWithComments/l2arctic_affricates/*.wavEach wav has a matching
.txtshowing the corrected token transcription vs the old joined parse. To my very biased ears, the fixes sound correct but feel free to verify. specifically verify you agree the "and jargon" one should be ʒ "zsh" not dʒ "dzh"Updated:
ipa_tokensfrom TextGrid phone boundaries.ipa_tokensdirectly when present, sot + ʃ/d + ʒare not accidentally merged intotʃ/dʒ.ipa_tokens.After this PR:
ipa_tokensin a separate PR.