fix(linux): compile against the Flutter 3.44 Linux embedder#56
Open
ericgriffin wants to merge 1 commit into
Open
fix(linux): compile against the Flutter 3.44 Linux embedder#56ericgriffin wants to merge 1 commit into
ericgriffin wants to merge 1 commit into
Conversation
- FlTextureGL populate gained width/height out-params (6-arg signature); report the texture's stored dimensions. - Declare the EGLContext member that flutter_angle_plugin.cc assigns; it was missing from _FlutterAnglePlugin entirely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Linux plugin fails to compile on Flutter 3.44.x stable:
Fixes
FlTextureGL.populatesignature: the Flutter Linux embedder's populate virtual method takeswidth/heightout-parameters.FlAngleTextureGLalready stores both, so the callback now reports them.flutter_angle_plugin.ccassignsself->eglContextwhen creating the shared context, but_FlutterAnglePluginnever declared the member. AddedEGLContext eglContext;.Verification
Compiled and linked in a release Linux build (
flutter build linux --release) on Flutter 3.44.4 stable / clang 18 (Ubuntu, GitHub Actions) as part of an app depending on flutter_angle 0.4.1 with these two changes applied.