Repository navigation
fix(ui): flyouts and the tag input follow the theme's surface colours - #1654
Open
adnan-bhaldar wants to merge 1 commit into
Open
adnan-bhaldar wants to merge 1 commit into
adnan-bhaldar wants to merge 1 commit into
Conversation
Flyouts (the icon picker in the preset and group editors, the list of running apps on the Triggers page) drew Avalonia's own grey instead of the page's surface, so they ignored the accent tint of Material You and of a theme's surface colour. Only the colour picker's flyout had a style for it (FlyoutPresenter.nopadding). The card style now applies to every FlyoutPresenter. The chip input (TagEditor: "Never trigger in these apps", the extension chips on the Toolbar page, the include list on Watch folders) was drawn with Fluent's text box colours: a near-black fill and a light grey outline. Under Material You it now takes what the other inputs have (the SurfaceAlt fill, the faint outline and the Softness radius); hover and focus are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tip
Start the title with a prefix so the PR is labeled automatically:
feat:fix:docs:ci:build:i18n:Example:
fix(hwp): keep tables when converting to DOCXWhat does this change?
Two places drew Fluent's default colours instead of the app's theme, so they stood out next to the rest of the UI:
#2b2b2b). Only the colour picker's flyout had a card style. The existingFlyoutPresenter.nopaddingstyle (the page's surface, the faint outline, the Softness radius) now applies to everyFlyoutPresenter, so they follow Material You's accent tint and a theme's surface colour. The colour picker looks the same as before.TagEditor: "Never trigger in these apps", the extension chips on the Toolbar page, the include list on Watch folders) used Fluent's text box colours: a near-black fill and a light grey outline. Under Material You it now has theSurfaceAltfill, the faint outline and the Softness radius, like the other inputs. Hover and focus are unchanged.Only
src/Filee.App/App.axamlandsrc/Filee.App/Styles/TagEditor.axamlchange.Type of change
How was it tested?
dotnet format --verify-no-changesdotnet testScreenshots (UI changes)
Material You, dark theme.
Checklist
src/Filee.App/Assets/i18n/*.jsonfiles (no new UI strings)THIRD-PARTY-NOTICES.md(none added)