Skip to content

Remove the version number from the About page's "What's new" link (the pill already shows it) #1655

Open

Description

@adnan-bhaldar

What I noticed

On the About page the link under the description reads "What's new in Filee 2.5", right beside the v2.5.0 version pill. The pill already tells the user which version they have, so the number in the link says the same thing a second time.

Suggestion

Drop the {0} from whats_new.about_link, so the link reads just "What's new" (and the equivalent in the other languages).

Why

  • It repeats the pill. The version is already shown right next to the link.
  • Nothing is lost. The What's new window still says which release the slides are for, because whats_new.title ("What's new in Filee {0}") keeps its {0}. I'm only suggesting the About page link.
  • A shorter label fits more easily in the About card, especially in languages with longer words.

I checked whether this label needs maintenance each release. It doesn't: AboutPageViewModel fills the {0} from whatsNew.Latest.DisplayVersion (the newest slide deck up to the installed version). So this isn't about a stale label, only about the text being redundant.

What would change

  • src/Filee.App/ViewModels/Pages/AboutPageViewModel.cs (line 28): loc.Format("whats_new.about_link", deck.DisplayVersion) becomes loc["whats_new.about_link"]. The HasWhatsNew logic stays, so the link is still hidden when there are no slides.
  • whats_new.about_link in each of the 23 files in src/Filee.App/Assets/i18n/. This is not a pure find-and-replace, because the placement of {0} differs by language, for example "Filee {0} の新機能" (ja), "Filee {0}의 새 기능" (ko), "Neu in Filee {0}" (de). Each needs the number removed with the wording kept natural, and I'd leave translations I can't judge to be checked by native speakers.
  • tests/Filee.App.Tests/WhatsNewTests.cs (line 544): the test builds the expected text with Format("whats_new.about_link", "2.0") and would change to the plain key.

whats_new.title and the What's new window are untouched.

Question

Would you accept this? I'm happy to open a PR. If you prefer to keep the number, I understand, and I'll close this.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    questionFurther information is requested

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions