Repository navigation
Only trim spaces and tabs around header parameters - #364
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parse_options_headertrimmed parameter names and values withstrip(),rstrip()andlstrip()without arguments. Those remove all Unicode whitespace, and because the header is decoded as latin-1, the bytes0xA0and0x85count as whitespace too. Whitespace around a header parameter is only a space or a tab (RFC 9110 §5.6.3).form-data; name=voil\xc3\xa0nameisvoil\xc3nameisvoil\xc3\xa0form-data; name="a";\xa0filename="a.txt"filename\xa0filenameisn'tfilename, so the part is a fieldmultipart/form-data; boundary=XX\xa0XXXX\xa0Spaces and tabs are still trimmed, and quoted values are unchanged.
AI Disclaimer
This PR was developed with the assistance of either Claude or Codex. I've reviewed and verified the changes.