Skip to content

History component#35

Closed
bnmajor wants to merge 6 commits into
masterfrom
history-component
Closed

History component#35
bnmajor wants to merge 6 commits into
masterfrom
history-component

Conversation

@bnmajor

@bnmajor bnmajor commented Apr 8, 2026

Copy link
Copy Markdown
Collaborator
Screencast.from.04-09-2026.09.23.23.AM.webm

Depends on #34

bnmajor added 6 commits April 8, 2026 16:56
Do not import `Optional` or `Union`.

Signed-off-by: Brianna Major <brianna.major@kitware.com>
Signed-off-by: Brianna Major <brianna.major@kitware.com>
Signed-off-by: Brianna Major <brianna.major@kitware.com>
Signed-off-by: Brianna Major <brianna.major@kitware.com>
Signed-off-by: Brianna Major <brianna.major@kitware.com>
Signed-off-by: Brianna Major <brianna.major@kitware.com>
@bnmajor
bnmajor force-pushed the history-component branch from 6a552e8 to 0bd71c9 Compare April 9, 2026 13:25
@bnmajor bnmajor mentioned this pull request Apr 9, 2026
Base automatically changed from ui-layout to master June 5, 2026 15:39
@jlee-kitware

Copy link
Copy Markdown
Collaborator

Superseded: the conversation history drawer was harvested from this branch and incorporated into #45 (sessions model). Closing.

jlee-kitware added a commit that referenced this pull request Jun 30, 2026
History panel (cherry-picked and adapted from PR #35):
- New ui/layout/conversation_history.py: a browsable list of past
  conversation pairs with newest/oldest sort and a favorites filter.
  Clicking a card jumps to that conversation; a heart toggles favorite.
- Switch the app to SinglePageWithDrawerLayout and host the panel in the
  left drawer (bound to existing main_drawer, collapsed by default); the
  toolbar nav icon now toggles it instead of being hidden.
- Controllers navigate_to_conversation and toggle_favorite_conversation,
  plus history_sort_order / history_filter_mode / favorited_conversations
  state.

Per-conversation code state (new):
- generated_code, code_history and code_history_pos were global
  singletons, so editing code in one conversation and navigating away
  discarded the edit and bled undo/redo history across conversations.
- Add a server-side store keyed by a content hash of each pair. Navigating
  away saves the active (possibly hand-edited) code and history; arriving
  restores it, seeding from the original generated code on first visit.
  Keying by content hash is robust to index shifts and conversation reloads.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants