feat(endInteraction): add event for gathering camera state - #104
Merged
Merged
Conversation
Collaborator
Author
|
@jspanchu the new example trigger an error when toggling between remote/local... I'm not sure of the reason, but it would be great to look into it. |
Member
|
i started looking into it |
jspanchu
reviewed
Sep 23, 2026
- the `getState` serialized the render window, which poisoned the state of the render window with it's current `Size` value. This breaks future `update` calls because it tried to set canvas size before the render window could be bound to a canvas. This threw a `SyntaxError` but didn't really break functionality. - this commit grabs the interactor through the `invoke` route to avoid serializing the render window.
jspanchu
force-pushed
the
add-end-interaction-event
branch
from
September 23, 2026 01:33
5d67145 to
8742bc7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.