Skip to content

fix(export): add helper and expose new api on widget - #103

Merged
jourdain merged 8 commits into
masterfrom
add-exporter
Sep 21, 2026
Merged

jourdain merged 8 commits into
masterfrom
add-exporter

Conversation

@jourdain

Copy link
Copy Markdown
Collaborator

No description provided.

Comment thread examples/demo/export.py
from trame_vtklocal.utils import exporter


def build_vtk_pipeline():

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jspanchu it would be great to showcase a beautiful and complex scene instead of the cone. With Axis grid and more?

Are you interested to improve that before I merge this PR?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely. Will work on it. I’ve some ideas.

@jourdain
jourdain requested a review from jspanchu September 18, 2026 00:24
Comment thread src/trame_vtklocal/widgets/vtklocal.py
@jspanchu

Copy link
Copy Markdown
Member

LGTM

@codecov

codecov Bot commented Sep 18, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 21.08844% with 116 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.00%. Comparing base (10adfe5) to head (08b192e).
⚠️ Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
src/trame_vtklocal/utils/exporter.py 19.37% 104 Missing ⚠️
src/trame_vtklocal/widgets/vtklocal.py 33.33% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #103      +/-   ##
==========================================
- Coverage   56.71%   52.00%   -4.72%     
==========================================
  Files          12       13       +1     
  Lines         506      673     +167     
==========================================
+ Hits          287      350      +63     
- Misses        219      323     +104     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment on lines +305 to +315
function createClientSideObject(native, state) {
const objectId = nextClientId;
native.registerState({
...state,
Id: nextClientId++,
MTime: 1,
"vtk-object-manager-kept-alive": true,
});
native.updateObjectsFromStates();
return getVtkObject(objectId);
}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the best we can do for now without making a C++ change that unlocks the creation/destroy of objects in vtkRemoteSession

@jourdain
jourdain merged commit 78ccd25 into master Sep 21, 2026
5 of 7 checks passed
@jourdain
jourdain deleted the add-exporter branch September 21, 2026 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants