WIP: feat: support trame client_type="react" - #125
Open
patrickoleary wants to merge 1 commit into
Open
patrickoleary wants to merge 1 commit into
patrickoleary wants to merge 1 commit into
Conversation
Add react-components/ (the react counterpart of vue-vtk-js) providing VtkRemoteView, VtkLocalView and VtkRemoteLocalView, and select the client bundle based on server.client_type: the module setup loads trame-vtk.js + vue_use for vue clients, trame-vtk-react.js + react_use for the react client. Python widgets, serializers and wslink protocols are shared by both clients unchanged. fix: HybridView.update_camera used the long-gone Server.update API; now uses Server.js_call. This latent crash was unreachable from the vue client because the vue @onEndAnimation listener never matches the emitted EndAnimation event; the react components wire that camera-sync path, making the branch live.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add react-components/ (the react counterpart of vue-vtk-js) providing
VtkRemoteView, VtkLocalView and VtkRemoteLocalView, and select the
client bundle based on server.client_type: the module setup loads
trame-vtk.js + vue_use for vue clients, trame-vtk-react.js + react_use
for the react client. Python widgets, serializers and wslink protocols
are shared by both clients unchanged.
fix: HybridView.update_camera used the long-gone Server.update API;
now uses Server.js_call. This latent crash was unreachable from the vue
client because the vue @onEndAnimation listener never matches the
emitted EndAnimation event; the react components wire that camera-sync
path, making the branch live.