Skip to content

fix(vtk-module): route remaining serializer imports through vtk_module #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Thibault-Pelletier merged 2 commits into from
Aug 14, 2026
Merged

fix(vtk-module): route remaining serializer imports through vtk_module #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89d6368
fix(vtk-module): route remaining serializer imports through vtk_module
akaszynski Aug 13, 2026
5cef7f4
style: noqa E402 on the imports below the vtk_module preamble
akaszynski Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/trame_vtk/modules/vtk/serializers/data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@
vtk_module_name = os.environ.get("VTK_MODULE_NAME", "vtkmodules")
sys.modules["vtk_module"] = importlib.import_module(vtk_module_name)

from vtk_module.vtkCommonCore import vtkIdTypeArray # noqa: E402
from vtk_module.vtkFiltersGeometry import ( # noqa: E402
vtkCompositeDataGeometryFilter,
vtkDataSetSurfaceFilter,
)
from vtkmodules.vtkCommonCore import vtkIdTypeArray # noqa: E402

from .helpers import extract_required_fields, get_array_description # noqa: E402
from .registry import class_name # noqa: E402
Expand Down
16 changes: 11 additions & 5 deletions src/trame_vtk/modules/vtk/serializers/serialize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,16 @@
import importlib
import logging
import os
import sys

import vtk
vtk_module_name = os.environ.get("VTK_MODULE_NAME", "vtkmodules")
sys.modules["vtk_module"] = importlib.import_module(vtk_module_name)

from .cache import remove_from_cache
from .registry import SERIALIZERS, class_name
from .widgets import handle_widget
from vtk_module.vtkCommonCore import vtkCommand # noqa: E402

from .cache import remove_from_cache # noqa: E402
from .registry import SERIALIZERS, class_name # noqa: E402
from .widgets import handle_widget # noqa: E402

__all__ = ["serialize", "serialize_widget"]

Expand All @@ -20,7 +26,7 @@ def serialize(parent, instance, instance_id, context, depth):
serializer = SERIALIZERS.get(instance_type, None)
if instance_id not in DELETE_CALLBACKS:
instance.AddObserver(
vtk.vtkCommand.DeleteEvent, lambda *_a, **_k: remove(instance_id)
vtkCommand.DeleteEvent, lambda *_a, **_k: remove(instance_id)
)
DELETE_CALLBACKS.append(instance_id)

Expand Down
8 changes: 7 additions & 1 deletion src/trame_vtk/modules/vtk/serializers/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,13 @@
import base64
import hashlib
import importlib
import os
import sys

from vtkmodules.util import numpy_support
vtk_module_name = os.environ.get("VTK_MODULE_NAME", "vtkmodules")
sys.modules["vtk_module"] = importlib.import_module(vtk_module_name)

from vtk_module.util import numpy_support # noqa: E402


def rgb_float_to_hex(r, g, b):
Expand Down
Loading