Skip to content

fix: fix connection-mode - #9

Merged
munozco merged 1 commit into
Kitware:mainfrom
Jo-Byr:fix-connection-mode
Jun 19, 2026
Merged

munozco merged 1 commit into
Kitware:mainfrom
Jo-Byr:fix-connection-mode

Conversation

@Jo-Byr

@Jo-Byr Jo-Byr commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Move connection-mode attribute from Handle to NodeEditor Add isValidConnection to Handle

@Jo-Byr

Jo-Byr commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

@munozco I can't add you as a reviewer.

@munozco

munozco commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

isValidConnection is also a NodeEditor prop. Could you add it there too ?
(https://vueflow.dev/typedocs/interfaces/FlowProps.html#isvalidconnection)

@Jo-Byr
Jo-Byr force-pushed the fix-connection-mode branch from 1bcea65 to e6e466d Compare June 18, 2026 14:46
Comment thread src/trame_flow/widgets/flow/node_editor.py
Move connection-mode attribute from Handle to NodeEditor
Add isValidConnection to Handle
@Jo-Byr
Jo-Byr force-pushed the fix-connection-mode branch from e6e466d to 65c62dc Compare June 19, 2026 06:44
@munozco

munozco commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the contribution !

@munozco
munozco merged commit 85fcbff into Kitware:main Jun 19, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants