Repository navigation
Major cleanup - #12
Merged
Merged
Conversation
- Add a `test` extra so `nox -s tests` installs pytest with the package instead of falling back to the project venv; `dev` now includes it. - Remove the duplicated pre-commit step in CI (nox already runs lint). - Remove the unused docs/api/pylint nox sessions, the `plugins/` ruff ignores and tests/requirements.txt inherited from the template. - Fix the project description. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The highlight of a mesh fully east of the prime meridian (and west of the antimeridian) was offset by half the map width. Extract the region math into compute_data_regions() and cover it with tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Build a tiny SCRIP mesh and EAM data file on the fly (no data download) to test the mesh/column/surface readers (row order, dimension order, fill values, time slicing), the lat/lon/time helpers, histogram snapping and GlobalParameters region selection and field loading. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
FindSpecialVariable read the hyb coefficients from `_hyai[1]`, raising IndexError for files without a `lev` variable but with one hybrid pair, so the level coordinate was dropped. Should also be reported upstream (QuickView) since io/ is vendored. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Dock panels only exist client side and were added once per server, so a reload or a second tab showed an empty dock. Re-add them when the dock of a client is ready (addPanel is a no-op for existing panel ids). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Clamp time_index when time_values shrinks and don't index an empty list. - Reset color_by to "" (a str field) instead of None when nothing is loaded. - Log missing field metadata instead of printing it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
viz3d.py (~1400 lines) becomes analysis/viz3d/ with one mixin per concern: - constants.py: themes, marker sizes, export scale, ... - camera.py: north-up interactor style and camera reset/focus - scene.py: VTK pipelines and actors (_setup_vtk split per layer), render-time syncs of level labels and column spheres, theme colors - layers.py: reaction of the layers to the UI controls, find data - histogram.py: histogram figure and snap_bound() - probe.py: hover tooltip and click menu - export.py: high resolution PNG with scalar bars - view.py: Viz3D (pipeline inputs, reactivity bindings, UI) load_all_analysis() now imports analysis packages too (pkgutil), and as regular e3sm_siteview.analysis.* modules. Rendering on the regional sample data is pixel identical to the previous code. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jourdain
commented
Oct 14, 2026
| if len(_hyai) == 1: | ||
| hyai = data[_hyai[0]][:].flatten() | ||
| hybi = data[_hyai[1]][:].flatten() | ||
| hybi = data[_hybi[0]][:].flatten() |
Collaborator
Author
There was a problem hiding this comment.
FYI @berkgeveci for QuickView or the io lib we want to capture all the readers...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.