Create 01_two_sum.md - #4
Open
Kitaken0107 wants to merge 1 commit into
Open
Conversation
hayashi-ay
reviewed
Mar 14, 2024
| for j in range(i+1,len(nums),1): | ||
| if target == nums[i] + nums[j]: | ||
| return [i,j] | ||
| break |
Owner
Author
There was a problem hiding this comment.
返り値確定したら、その後の処理不要ですもんね。
理解しました。
コメントありがとうございます。
| for i in range(len(nums)): | ||
| table[nums[i]] = i | ||
| for i in range(len(nums)): | ||
| sub = target - nums[i] |
Owner
Author
There was a problem hiding this comment.
引き算の単語の最初の3文字を書いてみたのですが、
たしかに連想しづらいのとそもそも引き算の単語にする必要ないですね。
ベストものぱっと思いつかないですが、ほかの方の命名確認してみます。
TORUS0818
reviewed
Jun 4, 2024
| for i in range(len(nums)): | ||
| sub = target - nums[i] | ||
| if sub in table and table[sub] != i: | ||
| return [i,table[sub]] |
There was a problem hiding this comment.
return [i,table[sub]] -> return [i, table[sub]]
| for i in range(len(nums)): | ||
| for j in range(i+1,len(nums),1): | ||
| if target == nums[i] + nums[j]: | ||
| return [i,j] |
| def twoSum(self, nums: List[int], target: int) -> List[int]: | ||
|
|
||
| for i in range(len(nums)): | ||
| for j in range(i+1,len(nums),1): |
There was a problem hiding this comment.
for j in range(i+1,len(nums),1): -> for j in range(i+1, len(nums), 1):
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://leetcode.com/problems/two-sum/