Skip to content

fix: reject credentialed URLs for IPv6, punycode, and text fragments #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kikobeats merged 2 commits into from
Aug 5, 2026
Merged

fix: reject credentialed URLs for IPv6, punycode, and text fragments #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
403db69
fix: reject credentialed URLs for IPv6, punycode, and text fragments
cursoragent Jul 23, 2026
ac22920
refactor: fold the credential guard into the protocol check
Kikobeats Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ const REGEX_HTTP_PROTOCOL = /^https?:\/\//i

module.exports = url => {
try {
const { href, hostname, hash } = new URL(url)
if (!REGEX_HTTP_PROTOCOL.test(href)) return false
const { href, hostname, hash, username, password } = new URL(url)
if (!REGEX_HTTP_PROTOCOL.test(href) || username || password) return false
const isIPv6 = hostname.startsWith('[') && hostname.endsWith(']')
const isPunycode = punycodeRegex.test(hostname)
const hasTextFragment = hash.startsWith('#:~:text=')
Expand Down
4 changes: 4 additions & 0 deletions test/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,10 @@ const test = require('ava').default
'http://Http://xn--80a0aaa.xn--p1ai',
'http://Http://kikobeats.com',
'https://admin:admin@test-http-login.vercel.app',
'https://trusted.example@example.com/#:~:text=x',
'https://user:pass@example.com/#:~:text=Example',
'https://trusted.example@xn--80a0aaa.com/',
'http://user:pass@[::1]/',
'http:!!!\0',
'http://-kikobeats.com'
])
Expand Down