Skip to content

Fix/buffer loading #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oss-haertl wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix/buffer loading #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f100f7a
Do not flag data URIs as absolute
oss-haertl Jun 8, 2026
abb9fd4
Fix draco indices loading
oss-haertl Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions source/ResourceLoader/loader_utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,9 @@ class ResourceLoaderUtils {
* @returns {boolean} `true` if the URL is absolute, `false` otherwise.
*/
static isAbsoluteUrl(url) {
if (url.startsWith("data:")) {
return false;
}
const colonIndex = url.indexOf(":");
const slashIndex = url.indexOf("/");
return colonIndex !== -1 && (slashIndex === -1 || colonIndex < slashIndex);
Expand Down
8 changes: 7 additions & 1 deletion source/gltf/primitive.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,9 +394,15 @@ class gltfPrimitive extends GltfObject {

copyDataFromDecodedGeometry(gltf, dracoGeometry, primitiveAttributes) {
// indices
let indexBuffer = dracoGeometry.index.array;
if (this.indices !== undefined) {
let indexBuffer = this.loadArrayIntoArrayBuffer(
dracoGeometry.index.array,
dracoGeometry.index.array.constructor.name
);
this.loadBufferIntoGltf(indexBuffer, gltf, this.indices, 34963, "index buffer view");

// DRACO decoder always outputs uint32 indices
gltf.accessors[this.indices].componentType = GL.UNSIGNED_INT;
}

// Position
Expand Down